-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code breaks if < is used within the redactor field #24
Comments
Oh here is some copy to test with. WAO application upstream of anaerobic digestion is intended to enhance the biodegradability of the organic matter in the downstream AD reactor. For this duty, lower temperatures (100–200 °C) and pressures (<20 bar) are used, sometimes with the addition of a catalyst. The WAO performance is measured in terms of the increase in either the liquid−phase organic carbon, or the subsequent removal of volatile suspended solids (VSS) by the AD process. Most recently, there has been interest in the potentially high-value intermediate oxidation products (low molecular weight organic compounds such as acetic and propionic acid) generated by WAO. While these carboxylic acids are produced in appreciable concentrations by the WAO process, extracting and purifying them for reuse remains a challenge. Note the (< 20- bar ) [art in the first paragraph. |
Ouch. Thanks for reporting @terryupton – I'll have a look at this as soon as I have the time. I spent exactly 30 seconds thinking about this :D but if you need a temporary hotfix, you could maybe try to replace the {{ entry.body | replace({ '<': '%lessthan%' }) | retcon(...) | replace({ '%lessthan%': '<' }) }} |
Thanks @mmikkel - I am still in the development phase so it's not causing me a huge issue. However, hoping it isn't a hugely complicated fix for you. Look forward to the update/patch. :-) |
@terryupton I think I've got a fix for this issue – if you're able to help me test it, that'd be much appreciated.
I'll cut a new release once I'm confident I didn't break anything else (at that point you can do a simple Thanks! |
Hi @mmikkel - thanks for the prompt fix. I will certainly help to test. I will aim to get onto this today/tomorrow and pass some feedback. |
@terryupton I appreciate that, thanks! |
Hi @mmikkel - apologies a day later than I had hoped to get onto this. !@£$%^&*(){}[]_-+=~`;:'""|?><,. I am happy and confident this fix has resolved the issue, so on my part, feel free to commit and push this out. Thanks again. |
Thanks for the feedback @terryupton! Much appreciated. I'm going to try and get some additional testing done over the weekend and hopefully have a new release out early next week. |
Sounds good. |
Resolved in Retcon 2.2.0 |
Currently, have a situation where the less than character (<) is used within the redactor field.
What is occurring is that content is getting cut off just before this character appears until the next html character. In this instance a new
tag.
When outputting this natively with twig code the character renders and there are no issues.
Here is this code for the retcon use case:
I have tested with just
content|raw
with native twig output and it renders just fine.I have not explored a solution, but thought I would raise this issue as it has occurred.
Thanks.
The text was updated successfully, but these errors were encountered: