Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies, that have react-native as a peerDependency, resolve to the wrong version of react-native #9

Open
mmazzarolo opened this issue Nov 7, 2021 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@mmazzarolo
Copy link
Owner

See mmazzarolo/react-native-universal-monorepo#22 (comment) for more info on the issue.

Solution:
Update react-native-monorepo-tools to block react-native-reanimated/node_modules/react-native (or from react-native-svg, which is what I just tried). From my testing, just adding something like blockList.push(new RegExp(node_modules/react-native-svg/node_modules/react-native/.*)); at line 46 here should be enough (you can try editing it directly in your node_modules/react-native-monorepo-tools and restarting the metro server). Of course it'd need to be made a bit more dynamic (e.g., by applying this rule to all nohoisted libs) but it can be a starting point.

@mmazzarolo mmazzarolo added bug Something isn't working good first issue Good for newcomers labels Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant