Skip to content

Commit 0e90f1a

Browse files
Matheus MarchiniMatheus Marchini
Matheus Marchini
authored and
Matheus Marchini
committed
docs: warn users about non-ASCII paths on build
The build breaks if there's a non-ASCII character on the path to the building directory. Ref: nodejs#16278 Ref: nodejs#14336
1 parent dc92540 commit 0e90f1a

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

BUILDING.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,8 @@ Prerequisites:
215215
* **Optional** (to build the MSI): the [WiX Toolset v3.11](http://wixtoolset.org/releases/)
216216
and the [Wix Toolset Visual Studio 2017 Extension](https://marketplace.visualstudio.com/items?itemName=RobMensching.WixToolsetVisualStudio2017Extension).
217217

218-
If the path to your build directory contains a space, the build will likely fail.
218+
If the path to your build directory contains a space or a non-ASCII character, the
219+
build will likely fail.
219220

220221
```console
221222
> .\vcbuild

0 commit comments

Comments
 (0)