We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently the variables in the dataset are listed in constants.py. This is bad if the code is to be used with other datasets.
constants.py
Create a file variables.json in data/my_dataset/static that describe all variables. This includes:
variables.json
data/my_dataset/static
u_65
All of these should be listed in order with names. For the weather state variables, their weighting (as in parameter_weights.npy currently) should also be listed with them. We can then remove the lines https://github.com/joeloskarsson/neural-lam/blob/89a4c63370201c9ea1a5f04d4cf1e5e75b7cc83e/create_parameter_weights.py#L26-L31 that generate this weighting file. It is better to let this be something that is set manually when preparing a dataset.
parameter_weights.npy
Such a variables.json file could then be loaded into a VariableDescription object and used in the models. The variable dimensions https://github.com/joeloskarsson/neural-lam/blob/89a4c63370201c9ea1a5f04d4cf1e5e75b7cc83e/neural_lam/models/ar_model.py#L22-L24 should then be read from this object rather than hard-coded in a model definition.
VariableDescription
The text was updated successfully, but these errors were encountered:
Superseded by #23
Sorry, something went wrong.
No branches or pull requests
Currently the variables in the dataset are listed in
constants.py
. This is bad if the code is to be used with other datasets.Proposition
Create a file
variables.json
indata/my_dataset/static
that describe all variables. This includes:u_65
)All of these should be listed in order with names. For the weather state variables, their weighting (as in
parameter_weights.npy
currently) should also be listed with them. We can then remove the lines https://github.com/joeloskarsson/neural-lam/blob/89a4c63370201c9ea1a5f04d4cf1e5e75b7cc83e/create_parameter_weights.py#L26-L31 that generate this weighting file. It is better to let this be something that is set manually when preparing a dataset.Such a
variables.json
file could then be loaded into aVariableDescription
object and used in the models. The variable dimensions https://github.com/joeloskarsson/neural-lam/blob/89a4c63370201c9ea1a5f04d4cf1e5e75b7cc83e/neural_lam/models/ar_model.py#L22-L24 should then be read from this object rather than hard-coded in a model definition.The text was updated successfully, but these errors were encountered: