Add HHVM to Travis config. #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes a script that updates HHVM to the latest nightly build as the current release is missing some things that Phake requires (for example, the `Reflection`) class.
mlively
added a commit
that referenced
this pull request
Mar 5, 2014
Add HHVM to Travis config. Thanks for the contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #132 this PR adds a HHVM build to the Travis CI configuration. It also has a build step that updates HHVM to the latest nightly build, as the current HHVM release is missing PHP features that Phake requires.
I've also done just enough so that the tests do not produce fatal errors, though a good handful still fail.
While those failures are most certainly due to differences between HHVM and PHP proper, I hope you'll consider supporting HHVM even if it did mean some changes to the Phake codebase in the meantime :)