Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--output_dir does not do correct thing if --output_dir is a cloud path #34

Open
Vaishaal opened this issue Jul 21, 2023 · 1 comment
Open
Assignees

Comments

@Vaishaal
Copy link
Contributor

The datacomp repo is cloudpath aware but open_clip is not, so when we pass a cloudpath like s3:// ... to the open_clip training code it just creates a folder called s3 locally on the master node.

The correct thing to do here is to detect its a cloudpath, give a temporary local directory and enable remote_sync on open_clip

@Vaishaal Vaishaal self-assigned this Jul 21, 2023
@0x2b3bfa0
Copy link
Contributor

0x2b3bfa0 commented Sep 25, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants