[Fix] Fix primitives for json schema converter #264
Merged
+67
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangkuiyi
reviewed
Mar 28, 2025
| // If the rule name is root, we need to define the root rule instead of just using the | ||
| // cached rule. | ||
| return ebnf_script_creator_.AddRule(rule_name_hint, basic_rules_cache_[idx]); | ||
| } |
Contributor
There was a problem hiding this comment.
Would this change the behavior of the converter and make it tend to generate a new rule? @Ubospica
russellb
added a commit
to russellb/vllm
that referenced
this pull request
Mar 28, 2025
Our previous behavior with xgrammar was to ensure that the response was
valid JSON. When the json_object output format is requested, the correct
behavior is to ensure the response is a JSON object. Valid JSON could
also be an array, a string, or a number, which is not desired here.
The fix is to explicitly use a json schema of {"type": "object"}. An
upgrade to xgrammar is necessary to fix a bug with xgrammar's support of
this schema, so we upgrade to 0.1.17.
- mlc-ai/xgrammar#256
- mlc-ai/xgrammar#264
Signed-off-by: Russell Bryant <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the "root rule not found" issue for primitives in json schema converter.