Skip to content

Fix NVCC Warnings #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Fix NVCC Warnings #308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions include/tvm/runtime/logging.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,10 @@ class LogFatal {
#pragma disagnostic push
#pragma warning(disable : 4722)
#endif
[[noreturn]] ~LogFatal() TVM_THROW_EXCEPTION { GetEntry().Finalize(); }
[[noreturn]] ~LogFatal() TVM_THROW_EXCEPTION {
GetEntry().Finalize();
throw;
}
#ifdef _MSC_VER
#pragma disagnostic pop
#endif
Expand All @@ -366,7 +369,7 @@ class LogFatal {
this->file_ = file;
this->lineno_ = lineno;
}
[[noreturn]] TVM_NO_INLINE dmlc::Error Finalize() {
[[noreturn]] TVM_NO_INLINE dmlc::Error Finalize() TVM_THROW_EXCEPTION {
InternalError error(file_, lineno_, stream_.str());
#if DMLC_LOG_BEFORE_THROW
std::cerr << error.what() << std::endl;
Expand Down