Skip to content

Commit df5e3ff

Browse files
committed
Fix Warnings on MSVC and NVCC
1 parent 5547b16 commit df5e3ff

File tree

1 file changed

+17
-0
lines changed

1 file changed

+17
-0
lines changed

include/tvm/runtime/logging.h

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -352,10 +352,16 @@ class LogFatal {
352352
#ifdef _MSC_VER
353353
#pragma disagnostic push
354354
#pragma warning(disable : 4722)
355+
#elif defined(__CUDACC__)
356+
#pragma nv_exec_check_disable
357+
#pragma diag_suppress 1305
355358
#endif
356359
[[noreturn]] ~LogFatal() TVM_THROW_EXCEPTION { GetEntry().Finalize(); }
357360
#ifdef _MSC_VER
358361
#pragma disagnostic pop
362+
#elif defined(__CUDACC__)
363+
#pragma nv_exec_check_enable
364+
#pragma diag_default 1305
359365
#endif
360366
std::ostringstream& stream() { return GetEntry().stream_; }
361367

@@ -560,15 +566,26 @@ std::unique_ptr<std::string> LogCheckFormat(const X& x, const Y& y) {
560566
return LogCheck##name<int, int>(x, y); \
561567
}
562568

569+
#if defined(__GNUC__) || defined(__clang__) // GCC and Clang
563570
#pragma GCC diagnostic push
564571
#pragma GCC diagnostic ignored "-Wsign-compare"
572+
#elif defined(_MSC_VER) // MSVC
573+
#pragma warning(push)
574+
#pragma warning(disable : 4389) // '==' : signed/unsigned mismatch
575+
#endif
576+
565577
TVM_CHECK_FUNC(_LT, <)
566578
TVM_CHECK_FUNC(_GT, >)
567579
TVM_CHECK_FUNC(_LE, <=)
568580
TVM_CHECK_FUNC(_GE, >=)
569581
TVM_CHECK_FUNC(_EQ, ==)
570582
TVM_CHECK_FUNC(_NE, !=)
583+
584+
#if defined(__GNUC__) || defined(__clang__) // GCC and Clang
571585
#pragma GCC diagnostic pop
586+
#elif defined(_MSC_VER) // MSVC
587+
#pragma warning(pop)
588+
#endif
572589

573590
} // namespace detail
574591

0 commit comments

Comments
 (0)