add .eslintrc

Author: nightwing

.eslintignore

@@ -0,0 +1,22 @@
+lib/ace/mode/css/*
+lib/ace/mode/coffee/*
+lib/ace/mode/html/*
+lib/ace/mode/javascript/*
+lib/ace/mode/json/*
+lib/ace/mode/lua/*
+lib/ace/mode/php/*
+lib/ace/mode/xml/*
+lib/ace/mode/xquery/*
+lib/ace/mode/xquery.js
+lib/ace/test/asyncjs/
+lib/ace/lib/es5-shim.js
+lib/ace/keyboard/vim*.js
+experiments/
+tool/
+doc/
+build/
+demo/
+api/
+**/* *
+**/node_modules
+0*

.eslintrc

@@ -0,0 +1,105 @@
+{
+    "globals": {
+        define: true,
+        require: true,
+        exports: true,
+        module: true,
+        __dirname: true,
+        __filename: true,
+        process: true,
+        global: true,
+        importScripts: true,
+        document: true,
+        window: true,
+        location: true,
+        navigator: true,
+        console: true,
+        Worker: true,
+        postMessage: true,
+        setTimeout: true,
+        clearTimeout: true,
+        setInterval: true,
+        clearInterval: true,
+        Blob: true,
+        cvox: true,
+        alert: true,
+        prompt: true,
+        XMLHttpRequest: true,
+    },
+    "rules": {
+        curly: 0,
+        eqeqeq: 0,
+        no-underscore-dangle: 0,
+        comma-dangle: 2,
+        no-dupe-args: 2,
+        no-dupe-keys: 2,
+        no-duplicate-case: 2,
+        no-empty-character-class: 2,
+        no-empty: 0,
+        no-ex-assign: 2,
+        no-extra-parens: 0,
+        no-func-assign: 2,
+        no-inner-declarations: 2,
+        no-invalid-regexp: 2,
+        no-irregular-whitespace: 2,
+        no-negated-in-lhs: 2,
+        no-obj-calls: 2,
+        no-sparse-arrays: 2,
+        no-unexpected-multiline: 2,
+        use-isnan: 2,
+        valid-typeof: 2,
+        
+        accessor-pairs: 2,
+        complexity: 2,
+        dot-location: [2, "property"],
+        no-caller: 2,
+        no-case-declarations: 2,
+        no-div-regex: 2,
+        no-empty-label: 2,
+        no-empty-pattern: 2,
+        no-extra-bind: 2,
+
+        no-implied-eval: 2,
+        no-lone-blocks: 2,
+        no-native-reassign: 2,
+        no-new-func: 2,
+        no-new-wrappers: 2,
+        no-octal-escape: 2,
+        no-octal: 2,
+
+        no-redeclare: 0,
+        no-return-assign: 0,
+        no-script-url: 2,
+        no-self-compare: 2,
+        no-sequences: 2,
+        no-useless-call: 2,
+        yoda: 2,
+                
+        no-undef: 2,
+        no-redeclare: 0,
+        // no-unused-vars: 1,
+
+        //////////////////////////////////////////////////////////////////
+        //
+        // no-unreachable: 2,
+        // no-debugger: 2,
+        // no-proto: 2,
+        // no-regex-spaces: 2,
+        // no-extend-native: 2,
+        // no-useless-concat: 2,
+        // no-eval: 2,
+        // dot-notation: 2,
+        // no-alert: 2,
+        // no-extra-semi: 2, // doesn't handle ;(function() {})() pattern
+        // radix: 2,
+        // no-invalid-this: 2,
+        // no-param-reassign: 2,
+        // wrap-iife: 2,
+        // no-throw-literal: 2,
+        // no-multi-spaces: 2,
+        // no-new: 2,
+        // no-else-return: 2,
+        // no-unused-expressions: 2,
+        // no-use-before-define : [2, "nofunc"],
+    }
+}

.travis.yml

@@ -1,9 +1,15 @@
 language: node_js
 
 node_js:
-  - "0.10"
+    - "0.10"
+
+script:
+    - npm i
+    - npm i -g eslint
+    - eslint "lib/ace/**/*.js"
+    - npm test
 
 matrix:
-  fast_finish: true
+    fast_finish: true
 
 sudo: false

Makefile.dryice.js

@@ -237,7 +237,7 @@ function buildAceModuleInternal(opts, callback) {
         paths: {
             ace: ACE_HOME + "/lib/ace",
             "kitchen-sink": ACE_HOME + "/demo/kitchen-sink",
-            build_support:  ACE_HOME + "/build_support",
+            build_support:  ACE_HOME + "/build_support"
         },
         root: ACE_HOME
     };
@@ -287,7 +287,7 @@ function buildAceModuleInternal(opts, callback) {
 
         build.writeToFile({code: code}, {
             outputFolder: path.dirname(to),
-            outputFile: path.basename(to),
+            outputFile: path.basename(to)
         }, function() {});
 
         callback && callback(err, result);
@@ -337,7 +337,7 @@ function buildAce(options) {
     var snippetFiles = jsFileList("lib/ace/snippets");
     var modeNames = modeList();
 
-    buildCore(options, {outputFile: "ace.js"}, addCb()),
+    buildCore(options, {outputFile: "ace.js"}, addCb());
     // modes
     modeNames.forEach(function(name) {
         buildSubmodule(options, {
@@ -351,7 +351,7 @@ function buildAce(options) {
             addSnippetFile(name);
 
         buildSubmodule(options, {
-            require: ["ace/snippets/" + name],
+            require: ["ace/snippets/" + name]
         }, "snippets/" + name, addCb());
     });
     // themes
@@ -385,7 +385,7 @@ function buildAce(options) {
                 id: "ace/worker/worker",
                 transforms: [],
                 order: -1000
-            }],
+            }]
         }, "worker-" + name, addCb());
     });
     // 

lib/ace/commands/occur_commands.js

@@ -75,7 +75,7 @@ function OccurKeyboardHandler() {}
 
 oop.inherits(OccurKeyboardHandler, HashHandler);
 
-;(function() {
+(function() {
 
     this.isOccurHandler = true;
 

lib/ace/config.js

@@ -191,7 +191,7 @@ function init(packaged) {
     for (var key in scriptOptions)
         if (typeof scriptOptions[key] !== "undefined")
             exports.set(key, scriptOptions[key]);
-};
+}
 
 exports.init = init;
 

lib/ace/config_test.js

@@ -79,13 +79,13 @@ module.exports = {
                 set: function(val) {
                     this.x = val;
                 },
-                value: 7,
+                value: 7
             },
             initialValue: {
                 set: function(val) {
                     this.x = val;
                 },
-                initialValue: 8,
+                initialValue: 8
             },
             opt2: {
                 get: function(val) {

lib/ace/edit_session.js

@@ -1843,13 +1843,13 @@ var EditSession = function(text, mode) {
             // The document size is the current size - the extra width for tabs
             // and multipleWidth characters.
             var len = displayed.length;
-            displayed.join("").
+            displayed.join("")
                 // Get all the TAB_SPACEs.
-                replace(/12/g, function() {
+                .replace(/12/g, function() {
                     len -= 1;
-                }).
+                })
                 // Get all the CHAR_EXT/multipleWidth characters.
-                replace(/2/g, function() {
+                .replace(/2/g, function() {
                     len -= 1;
                 });
 
@@ -2466,7 +2466,7 @@ var EditSession = function(text, mode) {
                c >= 0xFE68 && c <= 0xFE6B ||
                c >= 0xFF01 && c <= 0xFF60 ||
                c >= 0xFFE0 && c <= 0xFFE6;
-    };
+    }
 
 }).call(EditSession.prototype);
 

lib/ace/ext/chromevox.js

@@ -579,14 +579,14 @@ var onSelectionChange = function(evt) {
  * @param {!Event} evt The event.
  */
 var onChange = function(delta) {
-  switch (data.action) {
+  switch (delta.action) {
   case 'remove':
-    cvox.Api.speak(data.text, 0, DELETED_PROP);
+    cvox.Api.speak(delta.text, 0, DELETED_PROP);
     /* Let the future cursor change event know it's from text change. */
     changed = true;
     break;
   case 'insert':
-    cvox.Api.speak(data.text, 0);
+    cvox.Api.speak(delta.text, 0);
     /* Let the future cursor change event know it's from text change. */
     changed = true;
     break;
@@ -891,7 +891,7 @@ var SHORTCUTS = [
 /**
  * Event handler for focus events.
  */
-var onFocus = function() {
+var onFocus = function(_, editor) {
   cvoxAce.editor = editor;
 
   /* Set up listeners. */
@@ -911,7 +911,7 @@ var onFocus = function() {
  * @param {Object} editor Editor to use.
  */
 var init = function(editor) {
-  onFocus();
+  onFocus(null, editor);
 
   /* Construct maps. */
   SHORTCUTS.forEach(function(shortcut) {

lib/ace/ext/keybinding_menu.js

@@ -69,7 +69,7 @@ define(function(require, exports, module) {
             el.innerHTML = '<h1>Keyboard Shortcuts</h1>' + commands + '</div>';
             overlayPage(editor, el, '0', '0', '0', null);
         }
-    };
+    }
     module.exports.init = function(editor) {
         Editor.prototype.showKeyboardShortcuts = function() {
             showKeyboardShortcuts(this);

lib/ace/ext/whitespace_test.js

@@ -111,7 +111,7 @@ module.exports = {
         assert.equal(indent.length, 1);
 
         next();
-    },
+    }
 
 };
 

lib/ace/incremental_search.js

@@ -92,7 +92,7 @@ function objectToRegExp(obj) {
 
 // iSearch class
 
-;(function() {
+(function() {
 
     this.activate = function(ed, backwards) {
         this.$editor = ed;

lib/ace/incremental_search_test.js

@@ -155,14 +155,14 @@ module.exports = {
     "test: backwards search" : function() {
         editor.moveCursorTo(1,0);
         iSearch.activate(editor, true);
-        iSearch.addString('1'); var range = iSearch.addString('2');;
+        iSearch.addString('1'); var range = iSearch.addString('2');
         testRanges("Range: [0/5] -> [0/3]", [range], "range");
         assert.position(editor.getCursorPosition(), 0, 3);
     },
 
     "test: forwards then backwards, same result, reoriented range" : function() {
         iSearch.activate(editor);
-        iSearch.addString('1'); var range = iSearch.addString('2');;
+        iSearch.addString('1'); var range = iSearch.addString('2');
         testRanges("Range: [0/3] -> [0/5]", [range], "range");
         assert.position(editor.getCursorPosition(), 0, 5);
 
@@ -173,7 +173,7 @@ module.exports = {
 
     "test: reuse prev search via option" : function() {
         iSearch.activate(editor);
-        iSearch.addString('1'); iSearch.addString('2');;
+        iSearch.addString('1'); iSearch.addString('2');
         assert.position(editor.getCursorPosition(), 0, 5);
         iSearch.deactivate();
 
@@ -184,14 +184,14 @@ module.exports = {
 
     "test: don't extend selection range if selection is empty" : function() {
         iSearch.activate(editor);
-        iSearch.addString('1'); iSearch.addString('2');;
+        iSearch.addString('1'); iSearch.addString('2');
         testRanges("Range: [0/5] -> [0/5]", [editor.getSelectionRange()], "sel range");
     },
 
     "test: extend selection range if selection exists" : function() {
         iSearch.activate(editor);
         editor.selection.selectTo(0, 1);
-        iSearch.addString('1'); iSearch.addString('2');;
+        iSearch.addString('1'); iSearch.addString('2');
         testRanges("Range: [0/0] -> [0/5]", [editor.getSelectionRange()], "sel range");
     },
 

lib/ace/keyboard/emacs_test.js

@@ -162,7 +162,7 @@ module.exports = {
         editor.execCommand("killLine");
         editor.execCommand("yank");
         assert.equal(editor.getValue(),"foo  \n Hello world\n  \n  123");
-    },
+    }
 
 };
 

lib/ace/keyboard/textarea.js

@@ -60,22 +60,22 @@ exports.handler = new HashHandler();
     command: "passKeysToBrowser"
 }, {
     command: "golineup",
-    bindKey: {win: null, mac: "Ctrl-P"},
+    bindKey: {win: null, mac: "Ctrl-P"}
 }, {
     command: "golinedown",
-    bindKey: {win: null, mac: "Ctrl-N"},
+    bindKey: {win: null, mac: "Ctrl-N"}
 }, {
     command: "gotoleft",    
-    bindKey: {win: null, mac: "Ctrl-B"},
+    bindKey: {win: null, mac: "Ctrl-B"}
 }, {
     command: "gotoright",
-    bindKey: {win: null, mac: "Ctrl-F"},
+    bindKey: {win: null, mac: "Ctrl-F"}
 }, {
     command: "gotolineend",
-    bindKey: {win: null, mac: "Ctrl-E"},
+    bindKey: {win: null, mac: "Ctrl-E"}
 }, {
     command: "gotolinestart",
-    bindKey: {win: null, mac: "Ctrl-A"},
+    bindKey: {win: null, mac: "Ctrl-A"}
 }
 ].forEach(function(k) {
     var bindKey = k.bindKey;