Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request schema validation #41

Closed
dveljacic opened this issue Apr 24, 2023 · 2 comments
Closed

Request schema validation #41

dveljacic opened this issue Apr 24, 2023 · 2 comments

Comments

@dveljacic
Copy link
Contributor

Hi @mkon,

I would really love to see the feature of Request schema validation working similarly to Response schema validation and I see you put it in Future Plans. Do you have any idea when this could be?

I would like to try implementing this myself but first wanted to check with you and see what you think about it, maybe you have some general guidelines or ideas you want me to follow or something like that.

Thank you in advance for your response.
Best regards.

@mkon
Copy link
Owner

mkon commented Apr 25, 2023

Hey @dveljacic,

I am currently working on a feature that allows generating some kind of coverage report and request body validation would be quite high on the list of the next things to work on, but I can not really say when that is going to happen. Most likely not within the next 1-2 months.

If you want to work on it, you are welcome to submit a PR and I will review it.

Some general ideas how to implement it:

  • add another validator class for the request body and include it in the list of validators
  • add a Request class similar to the Response class and a way to lookup the correct request from the doc similar to the response
  • Also it would make sense for me to bring the refactoring from Coverage reporting #40 upstream so we do not have too many conflicts

@dveljacic
Copy link
Contributor Author

Closed by: #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants