Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Different results when checking API breaking changes with static and dynamic analysis #277

Open
pawamoy opened this issue May 25, 2024 · 0 comments
Assignees
Labels
unconfirmed This bug was not reproduced yet

Comments

@pawamoy
Copy link
Member

pawamoy commented May 25, 2024

Description of the bug

While testing the recent force_inspection feature, I noticed that the results of the check command were different between static and dynamic analysis.

Investigate to confirm and fix.

To Reproduce

In Griffe's own repository, run the check command against two tags that are known to have breaking changes, or no breaking changes, with and without -X.

Expected behavior

No diff between static and dynamic analysis.

Environment information

griffe --debug-info  # | xclip -selection clipboard
  • System: Linux-6.9.1-arch1-2-x86_64-with-glibc2.39
  • Python: cpython 3.11.5 (/media/data/dev/griffe/.venv/bin/python)
  • Environment variables:
    • PYTHONPATH: /home/pawamoy/.local/pipx/venvs/pdm/lib/python3.11/site-packages/pdm/pep582
  • Installed packages:
    • griffe v0.44.1.dev1+gce1dcec.d20240504

Additional context

We could probably add a test that asserts equal results with both static and dynamic analysis.

@pawamoy pawamoy added the unconfirmed This bug was not reproduced yet label May 25, 2024
@pawamoy pawamoy self-assigned this May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unconfirmed This bug was not reproduced yet
Projects
None yet
Development

No branches or pull requests

1 participant