Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline annotations do not move when selecting text downwards #16

Closed
Arnesfield opened this issue Nov 22, 2024 · 2 comments
Closed

Inline annotations do not move when selecting text downwards #16

Arnesfield opened this issue Nov 22, 2024 · 2 comments

Comments

@Arnesfield
Copy link

Selecting text downwards does not move the inline annotations.

Rather, it gets mounted on the line where the selection started instead of following the selection.

And as expected, the hover popup does not show up when it's not on the same line as the cursor.

vscode-better-git-line-blame-selection-issue-2024-11-22.mp4

Also tested the inline annotations from GitLens and vscode-git-line-blame extensions and they all seem to properly move the inline annotations.

It's not that big of an issue, but it may feel inconsistent if the inline annotations move when selecting upwards but not downwards.

@mk12
Copy link
Owner

mk12 commented Nov 22, 2024

Ah, i just made it always go on the top line of the selection. I see what you mean though, going to the line where the cursor is would be better. I’ll fix this in the next release.

@mk12 mk12 closed this as completed in 894918c Nov 25, 2024
@mk12
Copy link
Owner

mk12 commented Nov 25, 2024

Fix published in 0.2.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants