Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding the license for the package itself into the thirdParty output #1685

Closed
mitar opened this issue Feb 29, 2024 · 7 comments
Closed

Comments

@mitar
Copy link

mitar commented Feb 29, 2024

I suggest that the package.json of the main package is read as well and added to the top of the thirdParty output (in that case though thirdParty is badly named, but I think it is still OK). Maybe an option includeSelf: true.

The reason for this is that if I make a web app which I license under some license which requires attribution (e.g., MIT) and then deploy that app. The deployed app has to satisfy the license as well for the main code and not just dependencies. So for the main code the requirement is attribution. So it should also be inside the file with all attributions/notices.

It makes even more sense if I imagine somebody else taking my open source web app and deploying it. Deployed app should include the source code license of the whole web app as that somebody is distributing the app.

@mjeanroy
Copy link
Owner

Hi,
I just released version 3.4.0 including the includeSelf option (as you suggested!), thanks again for the report :)

@mitar
Copy link
Author

mitar commented Apr 18, 2024

Awesome! Thank you!

@mitar
Copy link
Author

mitar commented May 14, 2024

I do not see 3.4.0 on NPM? https://www.npmjs.com/package/rollup-plugin-license

@mjeanroy
Copy link
Owner

Oups, good catch @mitar, I forgot to publish, I just did it :)

@mitar
Copy link
Author

mitar commented May 14, 2024

Thanks! I tested it now and I noticed one small issue. I have to set both includeSelf and includePrivate to include a private self package. I think includeSelf should have precedence and allow me to include self no matter if private or not. So that I can then use includePrivate to include private dependencies (or not).

@mjeanroy
Copy link
Owner

Hi @mitar,
Sorry for the delay, I just published version 3.4.1 with the fix!

@mitar
Copy link
Author

mitar commented Jun 21, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants