-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow adding the license for the package itself into the thirdParty output #1685
Comments
Hi, |
Awesome! Thank you! |
I do not see 3.4.0 on NPM? https://www.npmjs.com/package/rollup-plugin-license |
Oups, good catch @mitar, I forgot to publish, I just did it :) |
Thanks! I tested it now and I noticed one small issue. I have to set both |
Hi @mitar, |
Thanks! |
I suggest that the
package.json
of the main package is read as well and added to the top of the thirdParty output (in that case thoughthirdParty
is badly named, but I think it is still OK). Maybe an optionincludeSelf: true
.The reason for this is that if I make a web app which I license under some license which requires attribution (e.g., MIT) and then deploy that app. The deployed app has to satisfy the license as well for the main code and not just dependencies. So for the main code the requirement is attribution. So it should also be inside the file with all attributions/notices.
It makes even more sense if I imagine somebody else taking my open source web app and deploying it. Deployed app should include the source code license of the whole web app as that somebody is distributing the app.
The text was updated successfully, but these errors were encountered: