Skip to content

Commit a4a761a

Browse files
committed
fix: 🐛 auto appendChild works only for not defined remount
1 parent 2471f91 commit a4a761a

File tree

4 files changed

+13
-7
lines changed

4 files changed

+13
-7
lines changed

Diff for: packages/create-widget/views/preact/template.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"dependencies": {
3-
"@merkur/preact": "0.35.0"
3+
"@merkur/preact": "0.36.0"
44
},
55
"devDependencies": {
66
"enzyme": "3.11.0",

Diff for: packages/create-widget/views/svelte/template.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"dependencies": {
3-
"@merkur/svelte": "0.35.0"
3+
"@merkur/svelte": "0.36.0"
44
},
55
"devDependencies": {}
66
}

Diff for: packages/create-widget/views/uhtml/template.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"dependencies": {
3-
"@merkur/uhtml": "0.35.0"
3+
"@merkur/uhtml": "0.36.0"
44
},
55
"devDependencies": {}
66
}

Diff for: packages/integration-custom-element/src/index.js

+10-4
Original file line numberDiff line numberDiff line change
@@ -59,10 +59,16 @@ function registerCustomElement(options) {
5959
customElement: this,
6060
});
6161

62-
(await callbacks?.remount?.(this._widget, {
63-
shadow: this._shadow,
64-
customElement: this,
65-
})) ?? this._shadow.appendChild(widget.container);
62+
if (typeof callbacks?.remount === 'function') {
63+
await callbacks?.remount?.(this._widget, {
64+
shadow: this._shadow,
65+
customElement: this,
66+
});
67+
} else {
68+
widget.root = this._shadow;
69+
widget.customElement = this;
70+
this._shadow.appendChild(widget.container);
71+
}
6672

6773
return;
6874
}

0 commit comments

Comments
 (0)