SC2235

Author: m-1-k-3

CONTRIBUTING.md

@@ -66,8 +66,12 @@ It also sketches the typical integration process of patches.
 
 - Don't use backticks anymore, use $(..) instead
 
+- Don't use `grep -R` for recursive grep search. Instead use `find -type f -exec grep something {} \;` or use `grep -r`
+
 - Use double square \[[]] brackets (conditional expressions) instead of single square [] brackets
 
+- We require variable braces. Instead of using `$VARIABLE` please use `${VARIABLE}`
+
 - Whenever possible try to avoid `tr` `sed` `awk` and use bash internal functions instead, see e.g. [bash shell parameter substitution](http://www.cyberciti.biz/tips/bash-shell-parameter-substitution-2.html). Using bash internals is faster as it does not fork, fopen and pipes the results back.
 
 - At least ["weak quoting"](https://wiki.bash-hackers.org/syntax/quoting#weak_quoting) is required - unquoted variable processing is not permitted

README.md

@@ -74,7 +74,7 @@ sudo ./emba -l ~/log -f ~/firmware -p ./scan-profiles/default-scan-gpt.emba
 
 ```
 ## Quick start in firmware diffing mode
-For further details on EMBA's AI analysis engine check the [wiki](https://github.com/e-m-b-a/emba/wiki/Firmware-diffing).
+For further details on EMBA's firmware diffing mechanism check the [wiki](https://github.com/e-m-b-a/emba/wiki/Firmware-diffing).
 ```console
 sudo ./emba -l ~/log -f ~/1st-firmware -o ~/2nd-newer-firmware -t
 

modules/S02_UEFI_FwHunt.sh

@@ -29,7 +29,7 @@ S02_UEFI_FwHunt() {
   local MAX_MOD_THREADS=$((MAX_MOD_THREADS/2))
   local EXTRACTED_FILE=""
 
-  if [[ "${UEFI_VERIFIED}" -eq 1 ]] || ( [[ "${RTOS}" -eq 1 ]] && [[ "${UEFI_DETECTED}" -eq 1 ]] ); then
+  if [[ "${UEFI_VERIFIED}" -eq 1 ]] || { [[ "${RTOS}" -eq 1 ]] && [[ "${UEFI_DETECTED}" -eq 1 ]]; }; then
     print_output "[*] Starting FwHunter UEFI firmware vulnerability detection"
     for EXTRACTED_FILE in "${FILE_ARR_LIMITED[@]}"; do
       if [[ ${THREADED} -eq 1 ]]; then