Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use util.parseArgs instead of yargs #380

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Use util.parseArgs instead of yargs #380

wants to merge 8 commits into from

Conversation

mizdra
Copy link
Owner

@mizdra mizdra commented Sep 28, 2024

close: #374

@mizdra mizdra added the Type: Breaking Change Includes breaking changes label Sep 28, 2024
mizdra
mizdra commented Sep 28, 2024
View reviewed changes
src/cli/parse-argv.ts
Copy link
Owner Author

@mizdra mizdra Sep 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

result: 8d04f7c

mizdra
mizdra commented Sep 28, 2024
View reviewed changes
src/cli/parse-argv.ts

const { values, positionals } = parseArgs({
allowPositionals: true,
allowNegative: true,
Copy link
Owner Author

@mizdra mizdra Sep 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allowNegative requires Node.js v22.4.0+.

https://nodejs.org/api/util.html#utilparseargsconfig

@mizdra mizdra added the Status: Blocked Progress on the issue is Blocked label Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Blocked Progress on the issue is Blocked Type: Breaking Change Includes breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use util.parseArgs instead of yargs
1 participant
@mizdra