-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Crate Enhancements
by Anastasis Grammenos (gramanas)
Email: [email protected]
This is the final proposal with witch I got accepted as a participant in GSoC 2017.
Current State
- Currently planing for the Nested Crates feature.
A new filter is added in mixxx's search bar. User can now type crate:
and anything after that will get matched with the crates the user has
created, and display the results.
First of all a new search filter node was created to handle the crate
filtering. It is called CrateFilterNode
. Since the crates each song is
in can't be found by the library_cache_view
that mixxxlibraryfeature
provides I had to create a workaround in order for match()
and
toSql()
to work.
cratestorage
handles all the crate related database access, so I added
a few functions there to generate/run the SQL required both by match()
and toSql()
.
Then searchqueryparser
got modified to recognise the crate
keyword
and through the CrateFilterNode
generate the correct SQL query to get
the trackIds of the songs matching the crate the user has entered.
This will likely be developed on top of Library Redesign. With that in mind I'd like to add some notes on the implementation of the Nested Crates.
- QT Tree Model will be used for the nesting purposes.
- A new table in the database will hold the parent child relationship and aplly the nessecary restrictions. (Child can't be parent of it's parent nor itself)
- Crates can hold songs AND other crates.
- There is no limit to how deep you can get.
- A child can't have it's parent or it's parent's parent (etc) as a child.
- When the user picks a crate up the hierarchy it's implied that he wants all the songs under that crate AND the nested ones under it.
- The above serve as a custom tagging system for DJ's to organise their music library in every way imaginable.
For the nested crates to work, we need a viable option to save them in the database.
Basicaly I'll add a table
'' | ParentID | ChildID | Depth | ''
exaclty as in the example above.
Also I'll add a table with columns | CrateID | path |
where path is a
string that will get generated whenever the user updates the database by
creating/moving/renaming/deleting a crate. This will be used in the
crate: filter witch will itself be used to replace the way the crates
are currently displayed (by generated a query just like in the new
library redesign).
Since the way the user selects crates will change to reflect the way the rest of the library works, here I'll describe how the filter will work for the nested crates.
Consider the following example:
- Metal
- Progressive
* Instrumental
* Alternative
* Rock
* Instrumental
After each modification of the crate database by the user (add/delete/move/rename a crate), a string will be generated for each crate from the first table I mentioned above, and get stored to the path table, witch will correspond to the "path" of the crate in the tree. This path is actually quite useful.
It will look like this for the examples above:
/Metal
/Metal/Progressive
/Metal/Progressive/Instrumental
/Metal/Alternative
/Rock
/Rock/Instrumental
The text the user has inserted after crate:
filter will get matched to
this string, so that the user can narrow down his search either by
typing crate:rock crate:instrumental
(Here I assume that the
different filters are joined together by AND
) or
crate:rock/instrumental
to get everything under rock/instrumental.
Also since the new library has an exact filter match I will also add an
exact crate filter crate:=
for consistency.
* To get all the instrumental tracks of this library the user naturally
searches for crate:instrumental
All these will be shown to the user as a tree structure (again like the
new library) using the same method used by the tracks. When a user
selects a crate, a query will get generated to narrow the users view of
the library to the crate that he/she selected using the path
variable
described above.
While the user organises the library, he/she might want to see only the
tracks under crate /Metal
but not those in the nested crates
underneath. For this a checkbox will be implemented next to the tree.
When checked it will change the query generated by the action of
clicking a crate to something else that will only list the tracks under
/Metal
. This will be the exact crate filter crate:=
that matches
it's argument exactly to the path, so /Metal
crate gets returned but
not /Metal/Progressive
or /SomeOtherCrate/Metal
May 15 - June 5
- Crate Filter
- Crate Filter Tests
June 6 - June 15
- Plan for Nested Crates implementation
- Familiarize with the new library layout
- Start coding the new way to select crates (via query)
June 16 - June 26
- Get ready for the first evaluation
- Start modifying the database adding triggers and the new table
**June 27 - **
- TBA
In this section I will mark my progress with a weekly report about the stuff I've been up to with mixxx.
Since I am starting this at June 13 here is a summary of what has been done so far:
- Crate filter is merged in master.
- Crate filter tests as well.
- There was some issues with the filters with the new library redesign and there is an open PR at daschuer's repo to fix this.
June 12 - June 19
June 19 - June 26
June 26 - July 3
July 3 - July 10
July 10 - July 17
July 17 - July 24
July 24 - July 31
July 31 - August 7
August 7 - August 14
August 14 - August 21
August 21 - August 28
Mixxx is a free and open-source DJ software.
Manual
Hardware Compatibility
Reporting Bugs
Getting Involved
Contribution Guidelines
Coding Guidelines
Using Git
Developer Guide
Creating Skins
Contributing Mappings
Mixxx Controls
MIDI Scripting
Components JS
HID Scripting