Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WOverview: shift hotcue popup left if it would exceed screen width #2663

Merged
merged 4 commits into from
May 15, 2020

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Apr 14, 2020

before:
Screenshot from 2020-04-13 20-38-11

after:
Screenshot from 2020-04-13 20-37-01

src/widget/woverview.cpp Outdated Show resolved Hide resolved
@uklotzde
Copy link
Contributor

@Be-ing Maybe util/widgethelper.h/.cpp? We already have a util/desktophelper.h/.cpp.

@Be-ing Be-ing added this to the 2.3.0 milestone May 7, 2020
@uklotzde
Copy link
Contributor

uklotzde commented May 7, 2020

@Be-ing How to proceed here? This is a major issue in full-screen mode and should be a beta blocker.

@Be-ing
Copy link
Contributor Author

Be-ing commented May 7, 2020

I'm unclear what the best way forward is here. We could make a utility function for this, or we could figure out how to get Qt to do this automatically for CueMenuPopup.

I don't agree that this is should block the beta release.

@ronso0
Copy link
Member

ronso0 commented May 7, 2020

We could make a utility function for this, or we could figure out how to get Qt to do this automatically for CueMenuPopup.

I suppose we can adopt something from
https://github.com/qt/qtbase/blob/dev/src/widgets/widgets/qmenu.cpp#L2337

@Be-ing Be-ing changed the base branch from master to 2.3 May 15, 2020 15:55
src/util/widgethelper.h Outdated Show resolved Hide resolved
src/util/widgethelper.h Outdated Show resolved Hide resolved
@uklotzde
Copy link
Contributor

Failure of the pre-commit job is unrelated. No need to wait fro the remaining CI builds after the latest changes. LGTM.

@uklotzde uklotzde merged commit c2827ee into mixxxdj:2.3 May 15, 2020
@Be-ing Be-ing deleted the hotcue_dialog_on_screen branch May 15, 2020 21:39
@hacksdump
Copy link
Contributor

Then hotcue menus aren't cut outside the window anymore. Thanks for the fix @Be-ing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants