-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WOverview: shift hotcue popup left if it would exceed screen width #2663
Conversation
@Be-ing Maybe util/widgethelper.h/.cpp? We already have a util/desktophelper.h/.cpp. |
@Be-ing How to proceed here? This is a major issue in full-screen mode and should be a beta blocker. |
I'm unclear what the best way forward is here. We could make a utility function for this, or we could figure out how to get Qt to do this automatically for CueMenuPopup. I don't agree that this is should block the beta release. |
I suppose we can adopt something from |
and account for height of screen too
f0c33c7
to
d01da12
Compare
Failure of the pre-commit job is unrelated. No need to wait fro the remaining CI builds after the latest changes. LGTM. |
Then hotcue menus aren't cut outside the window anymore. Thanks for the fix @Be-ing |
before:
after: