Skip to content

Search: add constant BPM filter bpm:const#14642

Merged
Swiftb0y merged 1 commit into
mixxxdj:2.6from
ronso0:search-bpm-const
Sep 24, 2025
Merged

Search: add constant BPM filter bpm:const#14642
Swiftb0y merged 1 commit into
mixxxdj:2.6from
ronso0:search-bpm-const

Conversation

@ronso0
Copy link
Copy Markdown
Member

@ronso0 ronso0 commented Apr 16, 2025 •
edited
Loading

I think this fixes #11064

Usage:
bpm:const/bpm:constant
-bpm:const/-bpm:constant for variable tempo

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 17, 2025

This PR is marked as stale because it has been open 90 days with no activity.

@github-actions github-actions Bot added the stale Stale issues that haven't been updated for a long time. label Jul 17, 2025
Swiftb0y
Swiftb0y requested changes Jul 17, 2025
View reviewed changes
Comment thread src/library/mixxxlibraryfeature.cpp
Comment thread src/library/searchquery.cpp
Swiftb0y
Swiftb0y reviewed Jul 17, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, I'm not an expert on the code though. Does ColumnCache need any changes too?

@ronso0
Copy link
Copy Markdown
Member Author

ronso0 commented Jul 18, 2025

Does ColumnCache need any changes too?

Yes, adding LIBRARYTABLE_BEATS_VERSION to that enum makes sense.

And I need to update all isColumnInternal()'s lists/cases to hide that colum.

@ronso0
Copy link
Copy Markdown
Member Author

ronso0 commented Jul 18, 2025

Btw: shall we target 2.6?
If approved, this is not touching/adding tr strings, all we need to do is update the manual.

@github-actions github-actions Bot removed the stale Stale issues that haven't been updated for a long time. label Jul 19, 2025
@ronso0 ronso0 force-pushed the search-bpm-const branch 2 times, most recently from 7e7b652 to efb3b3c Compare July 19, 2025 00:42
@ronso0
Copy link
Copy Markdown
Member Author

ronso0 commented Jul 20, 2025

ok, it finally builds on CI
I'll squash the fixup asap.

@ronso0 ronso0 force-pushed the search-bpm-const branch from a2a31c5 to ee3bb01 Compare July 20, 2025 20:48
@ronso0 ronso0 changed the base branch from main to 2.6 September 17, 2025 10:51
@github-actions github-actions Bot added controller mappings ui build code quality scanner soundsource browse developer experience Issues, bugs and PRs related to the development process, development environment & developer docs labels Sep 17, 2025
@ronso0 ronso0 mentioned this pull request Sep 17, 2025
Merged
@ronso0
Copy link
Copy Markdown
Member Author

ronso0 commented Sep 17, 2025

Rebased onto 2.6, everything works fine.
Ready to roll!

manual PR is mixxxdj/manual#794

@ronso0 ronso0 removed code quality scanner soundsource browse developer experience Issues, bugs and PRs related to the development process, development environment & developer docs labels Sep 23, 2025
@ronso0
Copy link
Copy Markdown
Member Author

ronso0 commented Sep 23, 2025

ping
Documentation is also ready mixxxdj/manual#794

Swiftb0y
Swiftb0y approved these changes Sep 24, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the ping. I already had reviewed everything, just forgot to give the LGTM. Will merge now.

@Swiftb0y Swiftb0y merged commit 44b9624 into mixxxdj:2.6 Sep 24, 2025
27 checks passed
@ronso0 ronso0 deleted the search-bpm-const branch September 24, 2025 10:45
@ronso0 ronso0 mentioned this pull request Sep 25, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Swiftb0y Swiftb0y Swiftb0y approved these changes

Assignees

No one assigned

Labels

library search

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Searching for tracks analyzed with variable BPM

2 participants

@ronso0 @Swiftb0y