Skip to content

Search: add BPM lock filter bpm:locked#14590

Merged
daschuer merged 1 commit into
mixxxdj:mainfrom
ronso0:search-bpm-lock
Apr 25, 2025
Merged

Search: add BPM lock filter bpm:locked#14590
daschuer merged 1 commit into
mixxxdj:mainfrom
ronso0:search-bpm-lock

Conversation

@ronso0
Copy link
Copy Markdown
Member

@ronso0 ronso0 commented Apr 4, 2025

Extends BpmFilterNode to check for locked arg:
bpm:locked / -bpm:locked

Fixes #14583

Copy link
Copy Markdown
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested, but code LGTM. Thank you.

@ronso0
Copy link
Copy Markdown
Member Author

ronso0 commented Apr 4, 2025

This is a no/very low risk change, IMHO it might even go to 2.5.1

Copy link
Copy Markdown
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

@daschuer daschuer merged commit 4402d31 into mixxxdj:main Apr 25, 2025
3 checks passed
@ronso0 ronso0 deleted the search-bpm-lock branch April 25, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Filter for searching tracks where BPM is locked or unlocked

3 participants