Skip to content

fix(controllers): fix crossfader cut on Traktor Kontrol Z1 #14451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoergAtGithub merged 4 commits into from
Jan 30, 2026
Merged

fix(controllers): fix crossfader cut on Traktor Kontrol Z1 #14451

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
69b9066
fix(controllers): fix crossfader cut on Traktor Kontrol Z1
ArthurVimond Mar 7, 2025
2a843bc
feat(controllers): apply crossfader calibration values
ArthurVimond Jan 29, 2026
b7f78b8
fix(controllers): add eslint definitions to fix pre-commit error
ArthurVimond Jan 29, 2026
b7b96e1
refactor(controllers): use separate crossfaderHandler()
ArthurVimond Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 44 additions & 1 deletion res/controllers/Traktor-Kontrol-Z1-scripts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
// Author: djantti
//

// eslint definitions
/* global controller, HIDController, HIDPacket */
class TraktorZ1Class {
constructor() {
this.controller = new HIDController();
Expand All @@ -16,11 +18,16 @@ class TraktorZ1Class {
this.vuLeftConnection = {};
this.vuRightConnection = {};
this.vuMeterThresholds = {"vu-30": (1 / 7), "vu-15": (2 / 7), "vu-6": (3 / 7), "vu-3": (4 / 7), "vu0": (5 / 7), "vu3": (6 / 7), "vu6": (7 / 7)};

Comment thread
ArthurVimond marked this conversation as resolved.
// Calibration data
this.rawCalibration = {};
this.calibration = null;
}

init(_id) {
this.id = _id;

this.calibrate();
this.registerInputPackets();
this.registerOutputPackets();
this.readCurrentPosition();
Expand Down Expand Up @@ -67,7 +74,7 @@ class TraktorZ1Class {
this.registerInputScaler(InputReport0x01, "[Channel2]", "volume", 0x19, 0xFFFF, this.parameterHandler.bind(this));

// Crossfader
this.registerInputScaler(InputReport0x01, "[Master]", "crossfader", 0x1B, 0xFFFF, this.parameterHandler.bind(this));
this.registerInputScaler(InputReport0x01, "[Master]", "crossfader", 0x1B, 0xFFFF, this.crossfaderHandler.bind(this));

this.controller.registerInputPacket(InputReport0x01);
}
Expand Down Expand Up @@ -116,6 +123,32 @@ class TraktorZ1Class {
this.lightDeck(false);
}

calibrate() {
this.rawCalibration.faders = new Uint8Array(0x20 * 3);
this.rawCalibration.faders.set(new Uint8Array(controller.getFeatureReport(0xD1)), 0x00);
this.rawCalibration.faders.set(new Uint8Array(controller.getFeatureReport(0xD2)), 0x20);
this.rawCalibration.faders.set(new Uint8Array(controller.getFeatureReport(0xD3)), 0x40);
this.calibration = this.parseRawCalibration();
}

parseRawCalibration() {
return {
crossfader: this.parseCrossfaderCalibration(0x3C),
};
}

parseCrossfaderCalibration(index) {
const data = this.rawCalibration.faders;
return {
min: this.parseUint16Le(data, index),
max: this.parseUint16Le(data, index+2),
};
}

parseUint16Le(data, index) {
return data[index] + (data[index+1]<<8);
}

readCurrentPosition() {
// Sync on-screen controls with controller knob positions
const report0x01 = new Uint8Array(controller.getInputReport(0x01));
Expand Down Expand Up @@ -209,6 +242,16 @@ class TraktorZ1Class {
engine.setParameter(field.group, field.name, field.value / 4095);
}

crossfaderHandler(field) {
// Crossfader value don't reach boundaries and need to use calibration values
// Also apply extra safe margins
const safeMargins = 5;
const min = this.calibration.crossfader.min;
const max = this.calibration.crossfader.max;
const value = script.absoluteLin(field.value, 0, 1, min + safeMargins, max - safeMargins);
engine.setParameter(field.group, field.name, value);
}

outputHandler(value, group, key) {
let ledValue;
if (value === 0 || value === false) {
Expand Down