From 3c379b70320000a2096dd8cb9105634c9f08f70d Mon Sep 17 00:00:00 2001 From: ronso0 Date: Mon, 31 Jul 2017 16:26:54 +0200 Subject: [PATCH 001/103] fix skin settings' Spinny/Cover options --- res/skins/Tango/skin_settings.xml | 72 ++++++++++++++++++++----------- 1 file changed, 47 insertions(+), 25 deletions(-) diff --git a/res/skins/Tango/skin_settings.xml b/res/skins/Tango/skin_settings.xml index a3a70ffa28ad..363f2348f261 100644 --- a/res/skins/Tango/skin_settings.xml +++ b/res/skins/Tango/skin_settings.xml @@ -246,19 +246,30 @@ Description: vertical me,min - + - [Tango],spinnyCoverBIG + [Tango],spinny_cover_none visible + 2 @@ -397,34 +408,45 @@ Description: - + vertical me,min - - + - [Tango],spinnyCoverBIG + [Tango],spinny_cover_none visible + 2 - + stacked From 8727e1994d4145af62316fb10274b9fe9b6dc75b Mon Sep 17 00:00:00 2001 From: ronso0 Date: Mon, 31 Jul 2017 16:27:34 +0200 Subject: [PATCH 002/103] make EffectSelector identical in left & right FX units --- res/skins/Tango/fx_selector_meta_left.xml | 72 ++++++++++------------- res/skins/Tango/style.qss | 25 ++------ 2 files changed, 36 insertions(+), 61 deletions(-) diff --git a/res/skins/Tango/fx_selector_meta_left.xml b/res/skins/Tango/fx_selector_meta_left.xml index eb20c97443d2..4ee2174a246f 100644 --- a/res/skins/Tango/fx_selector_meta_left.xml +++ b/res/skins/Tango/fx_selector_meta_left.xml @@ -22,11 +22,41 @@ Variables: - EffectTogglerLeft - horizontal + EffectToggler + stacked min,min + + + + + fxNameContainer + 72f,20f + horizontal + + 0me,1min + + fxName + + + + + 0me,1min + + + + + 90f,20f @@ -34,44 +64,6 @@ Variables: - - EffectToggler - stacked - min,min - - - - - - - fxNameContainer - 72f,20f - horizontal - - 0me,1min - - fxName - - - - - 0me,1min - - - - - - - diff --git a/res/skins/Tango/style.qss b/res/skins/Tango/style.qss index 088cccd964b5..6ab5e7db0de8 100644 --- a/res/skins/Tango/style.qss +++ b/res/skins/Tango/style.qss @@ -1127,8 +1127,7 @@ WBeatSpinBox { #EffectToggleButton { } - #EffectToggleButton[displayValue="0"]:hover { /* - border: 1px solid #ffb401; */ + #EffectToggleButton[displayValue="0"]:hover { border: 1px solid #ff8f00; } #EffectToggleButton[displayValue="1"]:hover { @@ -1137,8 +1136,7 @@ WBeatSpinBox { #EffectToggleButtonUnderlay[displayValue="0"] { background-color: #777777; } - #EffectToggleButtonUnderlay[displayValue="1"] { /* - background-color: #ffa601;*/ + #EffectToggleButtonUnderlay[displayValue="1"] { background-color: #ff8f00; /* yellow2 */ } #fxNameContainer { @@ -1152,7 +1150,6 @@ WBeatSpinBox { font-size: 13px/12px; } - /* TODO: copied from Deere */ WEffectSelector { font-family: Ubuntu; font-weight: normal; @@ -1168,31 +1165,17 @@ WBeatSpinBox { border: 0px solid #666666; border-radius: 2px; } - #EffectTogglerLeft > WEffectSelector { - margin: 0px -73px 0px 2px; - } WEffectSelector::drop-down { - /* This causes the Qt theme's widget style to magically not apply. Go figure. */ - border: 0; - } - #EffectTogglerLeft > WEffectSelector::drop-down { - subcontrol-origin: margin; - subcontrol-position: bottom left; - /* This causes the Qt theme's widget style to magically not apply. Go figure. */ border: 0; } WEffectSelector::down-arrow { width: 16px; - height: 16px; /* - margin-right: -2px; - image: url(skin:/buttons/btn_arrow_down.svg); - background-color: #FF00CA; */ + height: 16px; image: url(skin:/buttons/btn_fx_selector.svg); } WEffectSelector::down-arrow:hover { width: 16px; - height: 16px; /* - image: url(skin:/buttons/btn_arrow_down_hover.svg); */ + height: 16px; image: url(skin:/buttons/btn_fx_selector_hover.svg); } From 6f6fc7d4709f0d63435d2a31c50eca6c3425799f Mon Sep 17 00:00:00 2001 From: ronso0 Date: Mon, 31 Jul 2017 16:28:45 +0200 Subject: [PATCH 003/103] push FX units outwards to compensate FX label --- res/skins/Tango/fx_units_12.xml | 12 ++++++------ res/skins/Tango/fx_units_34.xml | 9 +++++---- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/res/skins/Tango/fx_units_12.xml b/res/skins/Tango/fx_units_12.xml index ff450a4aae57..b3101e9dd4b7 100644 --- a/res/skins/Tango/fx_units_12.xml +++ b/res/skins/Tango/fx_units_12.xml @@ -15,7 +15,7 @@ Description: EffectUnit1_maxi vertical - me,max + min,max