From c47c7d2ee95628f181bda42ea4da4d1f82703548 Mon Sep 17 00:00:00 2001
From: Antoine C <mixxx@acolombier.dev>
Date: Wed, 3 Apr 2024 23:31:23 +0100
Subject: [PATCH] feat: enable controller setting on MIDI

---
 src/controllers/midi/legacymidicontrollermappingfilehandler.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/controllers/midi/legacymidicontrollermappingfilehandler.cpp b/src/controllers/midi/legacymidicontrollermappingfilehandler.cpp
index 4735a6a32553..fc72a9c429ee 100644
--- a/src/controllers/midi/legacymidicontrollermappingfilehandler.cpp
+++ b/src/controllers/midi/legacymidicontrollermappingfilehandler.cpp
@@ -11,7 +11,6 @@ std::shared_ptr<LegacyControllerMapping>
 LegacyMidiControllerMappingFileHandler::load(const QDomElement& root,
         const QString& filePath,
         const QDir& systemMappingsPath) {
-    // TODO (XXX): support for controller settings
     if (root.isNull()) {
         return nullptr;
     }
@@ -26,6 +25,7 @@ LegacyMidiControllerMappingFileHandler::load(const QDomElement& root,
 
     // Superclass handles parsing <info> tag and script files
     parseMappingInfo(root, pMapping);
+    parseMappingSettings(root, pMapping.get());
     addScriptFilesToMapping(controller, pMapping, systemMappingsPath);
 
     QDomElement control = controller.firstChildElement("controls").firstChildElement("control");