From 8b8e228408a5b461d8d956a2b24f56d0d85178ac Mon Sep 17 00:00:00 2001 From: Owen Williams Date: Mon, 10 Apr 2023 10:57:38 -0400 Subject: [PATCH 1/2] Traktor S3: Fix script startup This data hack no longer works due to the the controller performance changes, and it turns out it is not needed, so remove it. --- res/controllers/Traktor-Kontrol-S3-hid-scripts.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/res/controllers/Traktor-Kontrol-S3-hid-scripts.js b/res/controllers/Traktor-Kontrol-S3-hid-scripts.js index 4e9cf47acdc5..3261f56f92c2 100644 --- a/res/controllers/Traktor-Kontrol-S3-hid-scripts.js +++ b/res/controllers/Traktor-Kontrol-S3-hid-scripts.js @@ -1750,10 +1750,6 @@ TraktorS3.Controller.prototype.registerInputPackets = function() { engine.connectControl(ch, "end_of_track", TraktorS3.bind(TraktorS3.Channel.prototype.endOfTrackHandler, chanob)); } - - // Dirty hack to set initial values in the packet parser - const data = [1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]; - TraktorS3.incomingData(data); }; TraktorS3.Controller.prototype.registerInputJog = function(message, group, name, offset, bitmask, callback) { From 0dbf7b80f60b2ae3d873681cabb2e22ffd89b564 Mon Sep 17 00:00:00 2001 From: Owen Williams Date: Sat, 22 Apr 2023 12:01:38 -0400 Subject: [PATCH 2/2] Also remove bad incomingData call from S2 mapping --- res/controllers/Traktor-Kontrol-S2-MK3-hid-scripts.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/res/controllers/Traktor-Kontrol-S2-MK3-hid-scripts.js b/res/controllers/Traktor-Kontrol-S2-MK3-hid-scripts.js index 704cabf2a71a..c99e3c03e463 100644 --- a/res/controllers/Traktor-Kontrol-S2-MK3-hid-scripts.js +++ b/res/controllers/Traktor-Kontrol-S2-MK3-hid-scripts.js @@ -223,10 +223,6 @@ TraktorS2MK3.registerInputPackets = function() { for (let i = 1; i <= 16; ++i) { engine.softTakeover("[Sampler" + i + "]", "pregain", true); } - - // Dirty hack to set initial values in the packet parser - const data = [1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]; - TraktorS2MK3.incomingData(data); }; TraktorS2MK3.registerInputJog = function(message, group, name, offset, bitmask, callback) {