From eb67b57d0a88c554234b87578fe1ea4ddc68221f Mon Sep 17 00:00:00 2001
From: Robbert van der Helm <mail@robbertvanderhelm.nl>
Date: Mon, 19 Dec 2022 21:12:54 +0100
Subject: [PATCH 1/2] Toggle entire quick effect chain enabled status

In the Latenight skin when clicking on the bypass buttons next to the
quick effect super knobs.
---
 res/skins/LateNight/mixer/quick_effect_knob_4decks.xml | 4 ++--
 res/skins/LateNight/mixer/quick_effect_knob_left.xml   | 4 ++--
 res/skins/LateNight/mixer/quick_effect_knob_right.xml  | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/res/skins/LateNight/mixer/quick_effect_knob_4decks.xml b/res/skins/LateNight/mixer/quick_effect_knob_4decks.xml
index 8c3ab7c52c45..c8d18a41e9cc 100644
--- a/res/skins/LateNight/mixer/quick_effect_knob_4decks.xml
+++ b/res/skins/LateNight/mixer/quick_effect_knob_4decks.xml
@@ -44,7 +44,7 @@
                       <Pressed scalemode="STRETCH">skin:/<Variable name="BtnScheme"/>/buttons/btn_<Variable name="BtnType"/>_eqkill_active.svg</Pressed>
                     </State>
                     <Connection>
-                      <ConfigKey><Variable name="QuickEffect"/>,enabled</ConfigKey>
+                      <ConfigKey><Variable name="QuickEffectGroup"/>,enabled</ConfigKey>
                       <ButtonState>LeftButton</ButtonState>
                     </Connection>
                     <Connection>
@@ -95,7 +95,7 @@
                       <Number>1</Number>
                     </State>
                     <Connection>
-                      <ConfigKey><Variable name="QuickEffect"/>,enabled</ConfigKey>
+                      <ConfigKey><Variable name="QuickEffectGroup"/>,enabled</ConfigKey>
                       <ButtonState>LeftButton</ButtonState>
                     </Connection>
                     <Connection>
diff --git a/res/skins/LateNight/mixer/quick_effect_knob_left.xml b/res/skins/LateNight/mixer/quick_effect_knob_left.xml
index 77831047bec1..89bd5b90ccde 100644
--- a/res/skins/LateNight/mixer/quick_effect_knob_left.xml
+++ b/res/skins/LateNight/mixer/quick_effect_knob_left.xml
@@ -34,7 +34,7 @@
                   <Pressed scalemode="STRETCH">skin:/<Variable name="BtnScheme"/>/buttons/btn_<Variable name="BtnType"/>_eqkill_active.svg</Pressed>
                 </State>
                 <Connection>
-                  <ConfigKey><Variable name="QuickEffect"/>,enabled</ConfigKey>
+                  <ConfigKey><Variable name="QuickEffectGroup"/>,enabled</ConfigKey>
                   <ButtonState>LeftButton</ButtonState>
                 </Connection>
               </PushButton>
@@ -82,7 +82,7 @@
                   <Number>1</Number>
                 </State>
                 <Connection>
-                  <ConfigKey><Variable name="QuickEffect"/>,enabled</ConfigKey>
+                  <ConfigKey><Variable name="QuickEffectGroup"/>,enabled</ConfigKey>
                   <ButtonState>LeftButton</ButtonState>
                 </Connection>
                 <Connection>
diff --git a/res/skins/LateNight/mixer/quick_effect_knob_right.xml b/res/skins/LateNight/mixer/quick_effect_knob_right.xml
index cc33abe52854..594a8f6f66ea 100644
--- a/res/skins/LateNight/mixer/quick_effect_knob_right.xml
+++ b/res/skins/LateNight/mixer/quick_effect_knob_right.xml
@@ -50,7 +50,7 @@
                   <Number>1</Number>
                 </State>
                 <Connection>
-                  <ConfigKey><Variable name="QuickEffect"/>,enabled</ConfigKey>
+                  <ConfigKey><Variable name="QuickEffectGroup"/>,enabled</ConfigKey>
                   <ButtonState>LeftButton</ButtonState>
                 </Connection>
                 <Connection>
@@ -83,7 +83,7 @@
                   <Pressed scalemode="STRETCH">skin:/<Variable name="BtnScheme"/>/buttons/btn_<Variable name="BtnType"/>_eqkill_active.svg</Pressed>
                 </State>
                 <Connection>
-                  <ConfigKey><Variable name="QuickEffect"/>,enabled</ConfigKey>
+                  <ConfigKey><Variable name="QuickEffectGroup"/>,enabled</ConfigKey>
                   <ButtonState>LeftButton</ButtonState>
                 </Connection>
               </PushButton>

From faf9393076351a3be30c674b4309635fcc96088f Mon Sep 17 00:00:00 2001
From: ronso0 <ronso0@mixxx.org>
Date: Tue, 20 Dec 2022 19:01:21 +0100
Subject: [PATCH 2/2] LateNight: fix QuickEffect knob visible connection

---
 res/skins/LateNight/mixer/quick_effect_knob_4decks.xml | 6 +++++-
 res/skins/LateNight/mixer/quick_effect_knob_left.xml   | 6 +++++-
 res/skins/LateNight/mixer/quick_effect_knob_right.xml  | 6 +++++-
 3 files changed, 15 insertions(+), 3 deletions(-)

diff --git a/res/skins/LateNight/mixer/quick_effect_knob_4decks.xml b/res/skins/LateNight/mixer/quick_effect_knob_4decks.xml
index c8d18a41e9cc..cb1ee3cd68ec 100644
--- a/res/skins/LateNight/mixer/quick_effect_knob_4decks.xml
+++ b/res/skins/LateNight/mixer/quick_effect_knob_4decks.xml
@@ -111,7 +111,11 @@
 
             </Children>
             <Connection>
-              <ConfigKey><Variable name="QuickEffect"/>,loaded</ConfigKey>
+              <ConfigKey><Variable name="QuickEffectGroup"/>,loaded_chain_preset</ConfigKey>
+              <Transform>
+                <IsEqual>0</IsEqual>
+                <Not/>
+              </Transform>
               <BindProperty>visible</BindProperty>
             </Connection>
           </WidgetGroup><!-- /Kill button + knob -->
diff --git a/res/skins/LateNight/mixer/quick_effect_knob_left.xml b/res/skins/LateNight/mixer/quick_effect_knob_left.xml
index 89bd5b90ccde..c4cd66c60ad7 100644
--- a/res/skins/LateNight/mixer/quick_effect_knob_left.xml
+++ b/res/skins/LateNight/mixer/quick_effect_knob_left.xml
@@ -98,7 +98,11 @@
       </WidgetGroup>
     </Children>
     <Connection>
-      <ConfigKey><Variable name="QuickEffect"/>,loaded</ConfigKey>
+      <ConfigKey><Variable name="QuickEffectGroup"/>,loaded_chain_preset</ConfigKey>
+      <Transform>
+        <IsEqual>0</IsEqual>
+        <Not/>
+      </Transform>
       <BindProperty>visible</BindProperty>
     </Connection>
   </WidgetGroup>
diff --git a/res/skins/LateNight/mixer/quick_effect_knob_right.xml b/res/skins/LateNight/mixer/quick_effect_knob_right.xml
index 594a8f6f66ea..bddfbbc95811 100644
--- a/res/skins/LateNight/mixer/quick_effect_knob_right.xml
+++ b/res/skins/LateNight/mixer/quick_effect_knob_right.xml
@@ -98,7 +98,11 @@
       </WidgetGroup>
     </Children>
     <Connection>
-      <ConfigKey><Variable name="QuickEffect"/>,loaded</ConfigKey>
+      <ConfigKey><Variable name="QuickEffectGroup"/>,loaded_chain_preset</ConfigKey>
+      <Transform>
+        <IsEqual>0</IsEqual>
+        <Not/>
+      </Transform>
       <BindProperty>visible</BindProperty>
     </Connection>
   </WidgetGroup>