Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import playlist when opening playlist with Mixxx #11178

Open
KristjanESPERANTO opened this issue Jan 2, 2023 · 13 comments · May be fixed by #11618 or #12243
Open

Import playlist when opening playlist with Mixxx #11178

KristjanESPERANTO opened this issue Jan 2, 2023 · 13 comments · May be fixed by #11618 or #12243

Comments

@KristjanESPERANTO
Copy link

Feature Description

The following feature would be very helpful: Mixx directly imports playlists that I open via a file manager.

Workflow: any file manager -> right-click on playlist (*.m3u) -> open with Mixxx -> Mixxx opens and imports the playlist

By the way: Thanks for this great software! 👏

@daschuer
Copy link
Member

daschuer commented Jan 4, 2023

The command line parser needs to check if the first argument is a file:
https://github.com/mixxxdj/mixxx/blob/main/src/util/cmdlineargs.cpp

Than put it into a new member: like m_playlistFile()

QList<QString> m_musicFiles; // List of files to load into players at startup

Use it here:


with:
void BasePlaylistFeature::slotCreateImportPlaylist() {

To load it into Auto DJ

@daschuer daschuer added the easy label Jan 4, 2023
@daschuer
Copy link
Member

daschuer commented Jan 4, 2023

Thank you for the feature request. This one is now waiting for a contributor who has interest to implement it.

@harsv689
Copy link

Sir, can i work on this ?

@KristjanESPERANTO
Copy link
Author

KristjanESPERANTO commented Jan 11, 2023

@harsv689 So far no one has reported working on this issue. I would be happy if you take care of it.

@shivang0-0
Copy link

I would like to work on this issue if it's still unassigned.

@daschuer
Copy link
Member

Go ahead. Do you need help?

@shivang0-0
Copy link

Go ahead. Do you need help?

Yes please, I was going through the following parser code here.

I guess, I do not need to add any extra positional argument like "playlist". The "file" positional argument can be used and in coreservices.cpp an else statement can be introduced for files with extension .m3u and then void BasePlaylistFeature::slotImportPlaylistFile(const QString& playlist_file) here can be used to import the playlist. Correct me, if I'm wrong in the above workflow please.

Moreover, while testing these changes out, is there a way faster that building the project again using cmake, like for verifying small changes?

@ronso0
Copy link
Member

ronso0 commented Jan 20, 2023

an else statement can be introduced for files with extension .m3u

Let's support all extensions that can be imported.
Just open a PR and the code be discussed much easier.

@shivang0-0
Copy link

an else statement can be introduced for files with extension .m3u

Let's support all extensions that can be imported. Just open a PR and the code be discussed much easier.

But, isn't the extension of all the exported playlist that needs to be imported is .m3u, so I was trying to identify .m3u files in particular. Any heads up, will be much appreciated on this @daschuer and @ronso0.

@ronso0
Copy link
Member

ronso0 commented Jan 21, 2023

Afaik Mixxx supports m3u, m3u8 and pls.
Just right-click on the Playlist feature and test what you can import.

@shivang0-0
Copy link

will

Afaik Mixxx supports m3u, m3u8 and pls. Just right-click on the Playlist feature and test what you can import.

will do a check around then, thanks @ronso0 !!

@shivang0-0
Copy link

@daschuer I've change certain aspects of the original void BasePlaylistFeature::slotCreateImportPlaylist() function to make it independent of the qAction but when calling this new function with a playlist file's path as an argument. I get this as an error "qualified name is not allowed". If possible can you review the code once?

@ronso0
Copy link
Member

ronso0 commented Jan 22, 2023

Just open a PR and the code be discussed much easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants