Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share functionlay has changed ? #204

Open
1 task done
freedomtrain opened this issue Jun 3, 2024 · 3 comments
Open
1 task done

Share functionlay has changed ? #204

freedomtrain opened this issue Jun 3, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@freedomtrain
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Before the current changes there was a share icon available to so that the query with reply could be shared with others.
This seems to not be available with the current code ?

Expected Behavior

We should have the ability to share results from results page.

Steps To Reproduce

Ask a question and not the share icon is not here

Environment

- OS: MacOS 
- Browser:Chrome

Anything else?

No response

@miurla
Copy link
Owner

miurla commented Jun 4, 2024

It can be enabled with the environment variable enable_share.
Please see the PR for details: #142

@miurla miurla closed this as completed Jun 4, 2024
@freedomtrain
Copy link
Author

freedomtrain commented Jun 4, 2024 via email

@miurla
Copy link
Owner

miurla commented Jun 4, 2024

It seems that is only accessible by using the saved queries from the history panel.

Sorry, I understood. Due to the removal of router.refresh(), the share button does not become active.
ref: #197

@miurla miurla reopened this Jun 4, 2024
@miurla miurla added the bug Something isn't working label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants