fix(frontend): 通知音がほぼ同時に鳴った場合は再生をブロックするように（音割れ防止） #12433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakkokari-gtyih
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #12433 +/- ##
===========================================
- Coverage 78.69% 78.55% -0.14%
===========================================
Files 178 177 -1
Lines 23605 23486 -119
Branches 496 496
===========================================
- Hits 18576 18450 -126
- Misses 5029 5036 +7 ☔ View full report in Codecov by Sentry. |
kakkokari-gtyih
changed the title
|
同時鳴動のしきい値は25msとかなりシビアにしてあるので、重複の通知音もちゃんと鳴ります |
|
👍 |
anatawa12
reviewed
Nov 27, 2023
| if (sound.type == null || !canPlay) return; | ||
|
|
||
| canPlay = false; | ||
| playFile(sound.type, sound.volume).then(() => { |
There was a problem hiding this comment.
playFileがエラーしたときに音が一切鳴らなくなりそうで若干不安な気がしますが大丈夫そうですかね
There was a problem hiding this comment.
@anatawa12 1dd7916単体でPRとか立ててもらえます…？
anatawa12
pushed a commit
to anatawa12/misskey
that referenced
this pull request
Nov 27, 2023
* (fix) 通知音がダブって音割れしないように * Update Changelog
anatawa12
added a commit
to anatawa12/misskey
that referenced
this pull request
Nov 27, 2023
anatawa12
added a commit
to anatawa12/misskey
that referenced
this pull request
Nov 28, 2023
syuilo
pushed a commit
that referenced
this pull request
Nov 29, 2023
* chore: 音声が一切鳴らなくなる可能性を軽減 #12433 (comment) * chore: IIFEではなくPromise.prototype.finallyを使用するように
anatawa12
added a commit
to anatawa12/misskey
that referenced
this pull request
Nov 29, 2023
* chore: 音声が一切鳴らなくなる可能性を軽減 misskey-dev#12433 (comment) * chore: IIFEではなくPromise.prototype.finallyを使用するように
camilla-ett
pushed a commit
to kaseiski/misskey
that referenced
this pull request
Jan 2, 2024
* (fix) 通知音がダブって音割れしないように * Update Changelog
camilla-ett
pushed a commit
to kaseiski/misskey
that referenced
this pull request
Jan 2, 2024
* chore: 音声が一切鳴らなくなる可能性を軽減 misskey-dev#12433 (comment) * chore: IIFEではなくPromise.prototype.finallyを使用するように
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
通知音が25ms以内に複数回鳴りそうになったらブロックするようにした
Why
Fix #12412
Additional info (optional)
Checklist