Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(frontend): Better Timeline(MkPagination) Experience #11066

Merged
merged 8 commits into from
Jul 4, 2023
Merged

Conversation

tamaina
Copy link
Contributor

@tamaina tamaina commented Jul 2, 2023

タイムライン(MkPagination)の体験を改善

What

  • API応答前はストリーミングの内容が殺されていたのを、ストリーミングの内容を表示するように
  • idで重複を排除する
  • fetchMore/fetchMoreAheadに間隔の時間制限(600ms)をつける

Why

APIの応答が遅くてもストリーミングは先に来ることが多いので、ストリーミングの内容を表示することで体験を改善するようにする

Additional info (optional)

p1.a9z.devに適用

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@tamaina tamaina requested a review from syuilo July 2, 2023 04:49
@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jul 2, 2023
@github-actions github-actions bot requested a review from acid-chicken July 2, 2023 04:50
@codecov
Copy link

codecov bot commented Jul 2, 2023

Codecov Report

Merging #11066 (a9f36ab) into develop (61e7eb8) will decrease coverage by 0.03%.
The diff coverage is 94.54%.

❗ Current head a9f36ab differs from pull request most recent head de07370. Consider uploading reports for the commit de07370 to get more accurate results

@@             Coverage Diff             @@
##           develop   #11066      +/-   ##
===========================================
- Coverage    77.48%   77.46%   -0.03%     
===========================================
  Files          909      907       -2     
  Lines        91645    91554      -91     
  Branches      7572     7573       +1     
===========================================
- Hits         71014    70919      -95     
- Misses       20631    20635       +4     
Impacted Files Coverage Δ
packages/frontend/src/components/MkPagination.vue 98.77% <94.54%> (-1.23%) ⬇️

... and 4 files with indirect coverage changes

@tamaina
Copy link
Contributor Author

tamaina commented Jul 2, 2023

この実装だと遡りできないじゃん

@tamaina tamaina changed the title enhance(frontend): Better MkPagination Appearance enhance(frontend): Better Timeline(MkPagination) Experience Jul 2, 2023
@tamaina
Copy link
Contributor Author

tamaina commented Jul 2, 2023

ユーザーのファイル付き投稿の挙動が変

@tamaina
Copy link
Contributor Author

tamaina commented Jul 4, 2023

itemsをMapにするか

@tamaina
Copy link
Contributor Author

tamaina commented Jul 4, 2023

Mapにしてみた

パフォーマンスは知らない(

@tamaina tamaina merged commit 92d9946 into develop Jul 4, 2023
@tamaina tamaina deleted the tlload branch July 4, 2023 15:59
slofp pushed a commit to Secineralyr/misskey.dream that referenced this pull request Jul 21, 2023
…dev#11066)

* enhance(frontend): Better MkPagination Appearance

* fix

* fix

* 新規投稿が空でも先頭に戻ったらunshiftItemsする

* use Map

* refactor, 型エラー潰し

* refactor
u1-liquid added a commit to u1-liquid/misskey that referenced this pull request Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant