Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: 13.7.3 #10048

Merged
merged 29 commits into from
Feb 23, 2023
Merged

Release: 13.7.3 #10048

merged 29 commits into from
Feb 23, 2023

Conversation

syuilo
Copy link
Member

@syuilo syuilo commented Feb 23, 2023

What

Why

Additional info (optional)

syuilo and others added 27 commits February 23, 2023 08:23
Windowsだとエラーが出るため
* feat: add optional swc

* fix: windowsで動かない現象を修正

* fix: fix swc path alias

* fix: docker build時に`Host key verification failed`と言われてgitリポジトリからパッケージをインストールできないのでssh -> htpsに変更
* feat: add optional swc

* fix: windowsで動かない現象を修正

* fix: fix swc path alias

* fix: docker build時に`Host key verification failed`と言われてgitリポジトリからパッケージをインストールできないのでssh -> htpsに変更

* feat(server): add @swc/core-android-arm64 to optional

* fix: conflict
* wip

* fix

* create migration

* oops

* fix front const

* changelog

* fix type

* fix

* wip

* Revert "wip"

This reverts commit 6cdb360.

* enumのこす

* fix

---------

Co-authored-by: syuilo <[email protected]>
@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Feb 23, 2023
@syuilo
Copy link
Member Author

syuilo commented Feb 23, 2023

CI通たらマージ

@syuilo
Copy link
Member Author

syuilo commented Feb 23, 2023

push と pull_request で二重に実行されてるの無駄感

@tamaina
Copy link
Contributor

tamaina commented Feb 23, 2023

Publish Docker imageを待つ必要性とは

@syuilo
Copy link
Member Author

syuilo commented Feb 23, 2023

Docker関連で問題があったら失敗すると思うから待つ意味はありそう

@tamaina
Copy link
Contributor

tamaina commented Feb 23, 2023

確かに

@syuilo
Copy link
Member Author

syuilo commented Feb 23, 2023

とはいえ遅すぎるのはどうにかしたい

@tamaina
Copy link
Contributor

tamaina commented Feb 23, 2023

arm64はどうしても遅くなる

@tamaina
Copy link
Contributor

tamaina commented Feb 23, 2023

履歴見てみたら30分近くかかるらしい

@tamaina
Copy link
Contributor

tamaina commented Feb 23, 2023

30分超えたわ

@syuilo
Copy link
Member Author

syuilo commented Feb 23, 2023

tasukete

@tamaina
Copy link
Contributor

tamaina commented Feb 23, 2023

@tamaina
Copy link
Contributor

tamaina commented Feb 23, 2023

viteにめっちゃ時間がかかっているだけっぽいし、それはキャッシュできそうだな

@acid-chicken
Copy link
Member

その前の依存関係解決だけで 30 分以上使ってない?

@acid-chicken
Copy link
Member

終わらないとフルのログが見られないのでとりあえず終わるのを待たないといけない

@syuilo
Copy link
Member Author

syuilo commented Feb 23, 2023

gulpもやたら遅いし、結論としては全体的に遅いんだと思う

@tamaina
Copy link
Contributor

tamaina commented Feb 23, 2023

@syuilo
Copy link
Member Author

syuilo commented Feb 23, 2023

CPUが0.1Ghzくらいしかなさそう

@acid-chicken
Copy link
Member

QEMU ならそれはそうって感じだ

@syuilo
Copy link
Member Author

syuilo commented Feb 23, 2023

ヌァァァァァァァァァァァァァァァァァァァァァァァァァァァァァァァァァァンンンンオオオオンンオンオンオンオンンンンンンンンン゛ン゛!!!!!!!!!!!!!!!!

@acid-chicken
Copy link
Member

終わりそう

@acid-chicken
Copy link
Member

というか auto-merge 使えばいいんでない?

@tamaina
Copy link
Contributor

tamaina commented Feb 23, 2023

寝たのか

@tamaina tamaina merged commit 7c9330a into master Feb 23, 2023
@tamaina
Copy link
Contributor

tamaina commented Feb 23, 2023

リリースしちゃった

@tamaina
Copy link
Contributor

tamaina commented Feb 23, 2023

3人で確認しても無駄ということが証明された

@syuilo
Copy link
Member Author

syuilo commented Feb 23, 2023

3人で確認しても無駄ということが証明された

というと

@tamaina
Copy link
Contributor

tamaina commented Feb 24, 2023

push と pull_request で二重に実行されてるの無駄感

最初にNextのPull Requestを作っておいてPull Request用のCIにまとめるとか

@tamaina
Copy link
Contributor

tamaina commented Feb 24, 2023

というと

see 13.7.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants