Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status bar does not use the parameters in an RSS link #9517

Closed
icecake0107 opened this issue Jan 10, 2023 · 1 comment · Fixed by #14826
Closed

Status bar does not use the parameters in an RSS link #9517

icecake0107 opened this issue Jan 10, 2023 · 1 comment · Fixed by #14826
Labels
⚠️bug? This might be a bug

Comments

@icecake0107
Copy link

💡 Summary

According to the Hacker News RSS manual, subscribe to this link

https://hnrss.org/show?points=100&link=comments

Clicking the items should bring me directly to the Hacker News website instead of the submitted article’s URL

🥰 Expected Behavior

RSS should be queried with the parameters in the URL.

🤬 Actual Behavior

It ignores the parameters &parameter after the ?first parameter.

📝 Steps to Reproduce

  1. Open the settings panel
  2. Open status bar
  3. Use the link https://hnrss.org/show?points=100&link=comments
  4. Click save
  5. Click any item on the status bar
  6. It jumps to the article instead of HN comments page.

📌 Environment

Misskey version: 13.0.0-beta.37
Your OS: Ubuntu 22.04.1 LTS
Your browser: Firefox-1.8.01

@icecake0107 icecake0107 added the ⚠️bug? This might be a bug label Jan 10, 2023
@itsjustduc
Copy link

itsjustduc commented Oct 14, 2023

i believe the issue exists because misskey tries to pass the URL itself as a URL parameter, so the URL only lasts until the first & in reality. try using URL escape characters (%26 instead of & and %3F instead of ?, tho the latter might not be absolutely necessary).

edit: URL encoding reference
widget code
backend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️bug? This might be a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants