Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stream APIのEventEmitterに型定義する #7765

Closed
tamaina opened this issue Sep 5, 2021 · 3 comments · Fixed by #7769
Closed

Stream APIのEventEmitterに型定義する #7765

tamaina opened this issue Sep 5, 2021 · 3 comments · Fixed by #7769
Assignees
@tamaina
Labels
packages/backend Server side specific issue/PR 💚Refactor Rewriting code without changing behavior

Comments

@tamaina
Copy link
Contributor

tamaina commented Sep 5, 2021 •
edited
Loading

Summary

Misskey内部のStream/Channelまわりの型がないので、開発に支障をきたしている。

Stream/Channelにどのようなデータが流れてくるかがわからない。正確にすべてを把握するには、ストリーム名で全文検索するしかない。
（というか、しゅいろも正確に把握していないのでは）

Stream/Channelまわりに型を付けてほしい。
@tamaina tamaina added ✨Feature This adds/improves/enhances a feature packages/backend Server side specific issue/PR 💚Refactor Rewriting code without changing behavior and removed ✨Feature This adds/improves/enhances a feature labels Sep 5, 2021
@tamaina
Copy link
Contributor Author

tamaina commented Sep 5, 2021

うーん、今やるか

@tamaina tamaina self-assigned this Sep 5, 2021
@tamaina tamaina changed the title Misskey内部のStream/Channelまわりの型がないので、開発に支障をきたしている EventEmitterに型定義する Sep 5, 2021
@tamaina
Copy link
Contributor Author

tamaina commented Sep 5, 2021

題名変えた

@tamaina
Copy link
Contributor Author

tamaina commented Sep 5, 2021

これ使ってもいい？

https://www.npmjs.com/package/strict-event-emitter-types

@tamaina tamaina changed the title EventEmitterに型定義する Stream APIのEventEmitterに型定義する Sep 5, 2021
This was referenced Sep 5, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tamaina tamaina

Labels
packages/backend Server side specific issue/PR 💚Refactor Rewriting code without changing behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: publishHogeStreamとStreamのEventEmitterに型定義する tamaina/misskey
1 participant
@tamaina