Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): clips/updateのdescriptionで空文字を許容するように #15429

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Feb 8, 2025

What

Why

Fix #15419

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Feb 8, 2025
@kakkokari-gtyih kakkokari-gtyih added this to the v2025.2.1 milestone Feb 8, 2025
Copy link
Contributor

github-actions bot commented Feb 8, 2025

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -30458,7 +30458,6 @@
                       "string",
                       "null"
                     ],
-                    "minLength": 1,
                     "maxLength": 2048
                   }
                 },
@@ -31916,7 +31915,6 @@
                       "string",
                       "null"
                     ],
-                    "minLength": 1,
                     "maxLength": 2048
                   }
                 },

Get diff files from Workflow Page

Copy link

codecov bot commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 38.64%. Comparing base (2f8d020) to head (5312a9f).

Files with missing lines Patch % Lines
...s/backend/src/server/api/endpoints/clips/create.ts 25.00% 3 Missing ⚠️
...s/backend/src/server/api/endpoints/clips/update.ts 25.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15429       +/-   ##
============================================
+ Coverage    18.81%   38.64%   +19.83%     
============================================
  Files          768     1607      +839     
  Lines       111510   204778    +93268     
  Branches      1236     4015     +2779     
============================================
+ Hits         20978    79141    +58163     
- Misses       89941   124995    +35054     
- Partials       591      642       +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend:test packages/backend Server side specific issue/PR
Projects
Status: Approved
Development

Successfully merging this pull request may close these issues.

クリップの説明欄を空に戻すことができない
2 participants