Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: frontend-embed/src/to-be-shared を共通化する #14530

Closed
1 task
kakkokari-gtyih opened this issue Sep 9, 2024 · 2 comments · Fixed by #14536
Closed
1 task

frontend: frontend-embed/src/to-be-shared を共通化する #14530

kakkokari-gtyih opened this issue Sep 9, 2024 · 2 comments · Fixed by #14536
Labels
✨Feature This adds/improves/enhances a feature 🔥high priority 💚Refactor Rewriting code without changing behavior

Comments

@kakkokari-gtyih
Copy link
Contributor

Summary

書いてある通り

Purpose

挙動をそろえる・保守性を上げるなど

Do you want to implement this feature yourself?

  • Yes, I will implement this by myself and send a pull request
@kakkokari-gtyih kakkokari-gtyih added the ✨Feature This adds/improves/enhances a feature label Sep 9, 2024
@syuilo
Copy link
Member

syuilo commented Sep 10, 2024

ref. #13929 (comment)

@syuilo syuilo added 💚Refactor Rewriting code without changing behavior 🔥high priority labels Sep 10, 2024
@kakkokari-gtyih
Copy link
Contributor Author

kakkokari-gtyih commented Sep 10, 2024

ref. #13929 (comment)

たぶん変更戻してもto-be-sharedの中身はほぼ変化なさそう(inject系の変更を戻した後、こちらで共通化だけ戻し直しているので)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨Feature This adds/improves/enhances a feature 🔥high priority 💚Refactor Rewriting code without changing behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants