Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

通知の受信設定で「相互フォロー」が正しく動作しない #13467

Closed
1 task done
zyoshoka opened this issue Feb 27, 2024 · 0 comments · Fixed by #13468
Closed
1 task done

通知の受信設定で「相互フォロー」が正しく動作しない #13467

zyoshoka opened this issue Feb 27, 2024 · 0 comments · Fixed by #13468
Labels
⚠️bug? This might be a bug packages/backend Server side specific issue/PR

Comments

@zyoshoka
Copy link
Contributor

zyoshoka commented Feb 27, 2024

💡 Summary

通知の受信設定で「相互フォロー」に設定しても、フォローしていないフォロワーからの通知やフォローされていないフォロー中のユーザからの通知が来るようになっています。

以下のロジックがおかしいのが原因です。

if (!isFollowing && !isFollower) {
return null;
}

🥰 Expected Behavior

通知の受信設定で「相互フォロー」に設定すると、フォローしていないフォロワーからの通知やフォローされていないフォロー中のユーザからの通知が来ない

🤬 Actual Behavior

通知の受信設定で「相互フォロー」に設定していても、フォローしていないフォロワーからの通知やフォローされていないフォロー中のユーザからの通知が来る

📝 Steps to Reproduce

No response

💻 Frontend Environment

No response

🛰 Backend Environment (for server admin)

* Installation Method or Hosting Service:
* Misskey: 2024.2.0
* Node:
* PostgreSQL:
* Redis:
* OS and Architecture:

Do you want to address this bug yourself?

  • Yes, I will patch the bug myself and send a pull request
@zyoshoka zyoshoka added the ⚠️bug? This might be a bug label Feb 27, 2024
@t1nyb0x t1nyb0x moved this to Triage in [BUG TRACKER] Backend Feb 27, 2024
@t1nyb0x t1nyb0x moved this from Triage to In Progress in [BUG TRACKER] Backend Feb 27, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in [BUG TRACKER] Backend Feb 28, 2024
@samunohito samunohito added the packages/backend Server side specific issue/PR label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️bug? This might be a bug packages/backend Server side specific issue/PR
Projects
No open projects
Status: Done
2 participants