Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2024.2.0-beta.8]api-docが開けなくなる #13129

Closed
1 task
1673beta opened this issue Feb 1, 2024 · 11 comments · Fixed by #13132
Closed
1 task

[2024.2.0-beta.8]api-docが開けなくなる #13129

1673beta opened this issue Feb 1, 2024 · 11 comments · Fixed by #13132
Labels
⚠️bug? This might be a bug

Comments

@1673beta
Copy link
Contributor

1673beta commented Feb 1, 2024

💡 Summary

https://{INSTANCE_URL}/api-docを叩くとOut of Memoryが必ず出るようになった

🥰 Expected Behavior

開ける

🤬 Actual Behavior

ロード後にOut of Memoryで開けない(Chromium)
ずっとロードしつづけて見れない(Firefox)

📝 Steps to Reproduce

2024.2.0-beta.8のサーバーでapi-docを開く

💻 Frontend Environment

* Model and OS of the device(s): Windows 11 23H2
* Browser: Vivaldi, Chrome, Firefox
* Server URL: koliosky.com, misskey.systems
* Misskey: 2024.2.0-beta.8

🛰 Backend Environment (for server admin)

* Installation Method or Hosting Service:
* Misskey:
* Node:
* PostgreSQL:
* Redis:
* OS and Architecture:

Do you want to address this bug yourself?

  • Yes, I will patch the bug myself and send a pull request
@1673beta 1673beta added the ⚠️bug? This might be a bug label Feb 1, 2024
@kakkokari-gtyih
Copy link
Contributor

api.jsonが重すぎるのか…?

@samunohito
Copy link
Member

ダウンロード自体はすぐに終わるようですが…レンダリング時に何らかの問題がある??
image

@samunohito
Copy link
Member

それか、redoc側のパーサが遅くなるようなapi.jsonになってしまっている…?

@samunohito
Copy link
Member

samunohito commented Feb 1, 2024

後者かも。なんか無限ループしてるっぽい
image

@samunohito
Copy link
Member

(この警告も解消しないといけないけど、今回は助けられた)

@syuilo
Copy link
Member

syuilo commented Feb 1, 2024

NotificationのSchema改善したのが影響してるのかしら

@syuilo
Copy link
Member

syuilo commented Feb 1, 2024

自分はそれくらいしか心当たりがない

@zyoshoka

This comment was marked as off-topic.

@hideki0403
Copy link
Contributor

無限ループであれば #12926 でPageBlockSchemaを追加したときに ref: PageBlock で自己参照を使用していたのでもしかしたらそれかもしれません...

const sectionBlockSchema = {
type: 'object',
properties: {
...blockBaseSchema.properties,
type: {
type: 'string',
optional: false, nullable: false,
enum: ['section'],
},
title: {
type: 'string',
optional: false, nullable: false,
},
children: {
type: 'array',
optional: false, nullable: false,
items: {
type: 'object',
optional: false, nullable: false,
ref: 'PageBlock',
},
},
},
} as const;

@samunohito
Copy link
Member

これ、どなたか動かれてます…?

@samunohito
Copy link
Member

おっ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️bug? This might be a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants