From 0bce53bbb3d542cf823bdaeb605b15f3d186dfc4 Mon Sep 17 00:00:00 2001 From: Jochen Jacobs Date: Thu, 14 Nov 2024 17:59:43 +0100 Subject: [PATCH] minor fixes --- src/render/ItemModel.ts | 11 +++++++++-- src/render/ItemRenderer.ts | 1 - 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/render/ItemModel.ts b/src/render/ItemModel.ts index fe66135..abfb45c 100644 --- a/src/render/ItemModel.ts +++ b/src/render/ItemModel.ts @@ -121,12 +121,13 @@ export namespace ItemModel { const property = Json.readString(root.property)?.replace(/^minecraft:/, '') switch (property){ - case 'using_item': case 'fishing_rod/cast': case 'selected': case 'carried': case 'extended_view': return (item, context) => context[property] ?? false + case 'using_item': + return (item, context) => (context.use_duration ?? -1) >= 0 case 'bundle/has_selected_item': return (item, context) => (context['bundle/selected_item'] ?? -1) >= 0 case 'broken': return (item, context) => { @@ -346,7 +347,13 @@ export namespace ItemModel { return ItemStack.fromNbt(selectedItemTag) }) - return selectedItem !== undefined ? ItemRenderer.getItemMesh(selectedItem, resources, {...context, 'bundle/selected_item': undefined}) : new Mesh() + return selectedItem !== undefined ? ItemRenderer.getItemMesh(selectedItem, resources, { + ...context, + 'bundle/selected_item': -1, + selected: false, + carried: false, + use_duration: -1 + }) : new Mesh() } } } diff --git a/src/render/ItemRenderer.ts b/src/render/ItemRenderer.ts index 601c208..64598ce 100644 --- a/src/render/ItemRenderer.ts +++ b/src/render/ItemRenderer.ts @@ -15,7 +15,6 @@ export interface ItemRendererResources extends BlockModelProvider, TextureAtlasP export type ItemRenderingContext = { display_context?: Display, - using_item?: boolean, 'fishing_rod/cast'?: boolean, 'bundle/selected_item'?: number, selected?: boolean,