Single quotation mark in branch name borks pull-request

[chris-morgan]

$ hub --version
git version 2.1.3
hub version 1.12.1
$ git rev-parse --abbrev-ref HEAD
impl-BorrowFrom-'static-slice-T-for-slice-T
$ hub pull-request -b rust-lang:master
/usr/lib/ruby/2.1.0/shellwords.rb:75:in `block in shellsplit': Unmatched double quote: "rev-list --cherry-pick --right-only --no-merges origin/impl-BorrowFrom-'static-slice-T-for-slice-T..." (ArgumentError)
    from /usr/lib/ruby/2.1.0/shellwords.rb:73:in `scan'
    from /usr/lib/ruby/2.1.0/shellwords.rb:73:in `shellsplit'
    from /usr/bin/hub:903:in `to_exec'
    from /usr/bin/hub:908:in `command_to_string'
    from /usr/bin/hub:867:in `block in initialize'
    from /usr/bin/hub:885:in `yield'
    from /usr/bin/hub:885:in `read'
    from /usr/bin/hub:1324:in `rev_list'
    from /usr/bin/hub:1720:in `pull_request'
    from /usr/bin/hub:1586:in `run'
    from /usr/bin/hub:2508:in `initialize'
    from /usr/bin/hub:2512:in `new'
    from /usr/bin/hub:2512:in `execute'
    from /usr/bin/hub:2563:in `<main>'

[owenthereal]

hub 1.x uses Shellwords to split arguments but it doesn't escape one single quote.

irb(main):002:0> require "shellwords"
=> true
irb(main):004:0> Shellwords.shellwords("impl-BorrowFrom-'static-slice-T-for-slice-T")
ArgumentError: Unmatched double quote: "impl-BorrowFrom-'static-slice-T-for-slice-T"
    from /opt/rubies/2.1.2/lib/ruby/2.1.0/shellwords.rb:75:in `block in shellsplit'
    from /opt/rubies/2.1.2/lib/ruby/2.1.0/shellwords.rb:73:in `scan'
    from /opt/rubies/2.1.2/lib/ruby/2.1.0/shellwords.rb:73:in `shellsplit'
    from (irb):4
    from /opt/boxen/rbenv/versions/2.1.2/bin/irb:11:in `<main>'

This is fixable in Ruby. But I just did a quick check, 2.2.0 doesn't have the issue. Do you mind upgrading to it? We'll be using the Go implementation moving forward so I'm reluctant to fix the Ruby code.

[owenthereal]

@chris-morgan Any update?

[chris-morgan]

I’m afraid I’ve been too lazy to switch my Arch Linux machine from community/hub 1.12.1-1 to aur/hub-bin 2.2.0-1 thus far.

[owenthereal]

Closing. Please reopen if the problem exists in newer version.

[mislav]

@chris-morgan I've released a bugfix version of Ruby hub, but you'll have to get community/hub updated to v1.12.3 now.

[owenthereal]

@mislav 👍