Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ApolloTracing with simple tracing extension #1092

Open
rafalp opened this issue Jun 2, 2023 · 3 comments
Open

Replace ApolloTracing with simple tracing extension #1092

rafalp opened this issue Jun 2, 2023 · 3 comments
Labels
decision needed Sounds like good idea, but will need closer scrutiny for final decision. enhancement New feature or request

Comments

@rafalp
Copy link
Collaborator

rafalp commented Jun 2, 2023

Instead of ApolloTracing (which is deprecated) we could implement a simple extension that adds extensions: {traces: []} object where each trace would be a separate {path: time: }.

I don't know how useful this would be to folk, but maybe it would have some utility as simple example extension?

@rafalp rafalp added enhancement New feature or request decision needed Sounds like good idea, but will need closer scrutiny for final decision. labels Jun 2, 2023
@dacevedo12
Copy link
Contributor

As an example in the docs or a examples/ directory, sure, but releasing it as an official feature I think would only make sense if/when GraphiQL2 adds support for a standardized format to visualize it

@dacevedo12
Copy link
Contributor

I think it's easier to advise using OTel with Jaeger to visualize traces locally

@rafalp
Copy link
Collaborator Author

rafalp commented Jun 5, 2023

World doesn't end on GraphiQL, OT and Jaeger tho. There are plenty GraphQL APIs here that are very limited in scope, run on things like AWS lambda and are interacted with through Insomnia or Postman. Having minimal zero-setup tracing extension to see how fast or slow resolvers are may be of use there.

Alternative is just marking ApolloTracing as deprecating and deleting it in one of future releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
decision needed Sounds like good idea, but will need closer scrutiny for final decision. enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants