Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ariadne.wsgi.GraphQL.get_request_data declares dict as return type but doesn't check for it. #1028

Open
rafalp opened this issue Feb 16, 2023 · 1 comment
Open

ariadne.wsgi.GraphQL.get_request_data declares dict as return type but doesn't check for it. #1028

rafalp opened this issue Feb 16, 2023 · 1 comment
Labels
bug Something isn't working to do

Comments

@rafalp
Copy link
Collaborator

rafalp commented Feb 16, 2023 •
edited
Loading

get_request_data calls extract_data_from_json_request that returns Any which is then casted to dict without any verification of it's type.

This verification still happens in graphql_sync so we are covered, but currently type is lying to developers working with the code.

We should change it's return type to Any and update the docs to reflect this.
@rafalp rafalp added the bug Something isn't working label Feb 16, 2023
@rexton12

This comment was marked as spam.

Sign in to view
@rafalp rafalp added the roadmap Feature that we want to have included label Jul 21, 2023
@TMuszczekk TMuszczekk added to do and removed roadmap Feature that we want to have included labels Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working to do
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rafalp @rexton12 @TMuszczekk