Skip to content

lib: do not require the list of ciphersuites sent by the client to be a proper set #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hannesm merged 1 commit into from
Jan 7, 2019
Merged

lib: do not require the list of ciphersuites sent by the client to be a proper set #390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/handshake_common.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,10 @@ let client_hello_valid ch =
not (empty ch.ciphersuites)
&&

(* android 4.4 and davdroid do not send proper sets!
(List_set.is_proper_set ch.ciphersuites)
&&
*)

(* TODO: if ecc ciphersuite, require ellipticcurves and ecpointformats extensions! *)
List_set.is_proper_set (extension_types to_client_ext_type ch.extensions)
Expand Down
1 change: 1 addition & 0 deletions pkg/pkg.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,5 @@ let () =
Pkg.test ~run:false ~cond:lwt "lwt/examples/echo_client_alpn" ;
Pkg.test ~run:false ~cond:lwt "lwt/examples/test_server" ;
Pkg.test ~run:false ~cond:lwt "lwt/examples/test_client" ;
Pkg.test ~run:false ~cond:lwt "lwt/examples/http_client" ;
]