Skip to content

Emit None when we are not able to be connected to the given endpoint#412

Merged
dinosaure merged 1 commit into
mirage:masterfrom
dinosaure:fix-unresolved-conduit-endpoint
Oct 7, 2020
Merged

Emit None when we are not able to be connected to the given endpoint#412
dinosaure merged 1 commit into
mirage:masterfrom
dinosaure:fix-unresolved-conduit-endpoint

Conversation

@dinosaure
Copy link
Copy Markdown
Member

It should fix in one way #397. Currently, we are able to clone an empty Git repository. However, if the transmission can not be initiate by conduit, the analyze of the PACK file still waiting inputs. In that case, we emit an empty stream to the analyzer and unlock it. The error is then correctly reported to git/irmin.

@dinosaure dinosaure force-pushed the fix-unresolved-conduit-endpoint branch from 6ce6de2 to 80f141b Compare October 6, 2020 16:27
@dinosaure dinosaure merged commit 2148240 into mirage:master Oct 7, 2020
dinosaure added a commit to dinosaure/opam-repository that referenced this pull request Jan 9, 2021
… git-unix (3.0.0)

CHANGES:

- Rewrite of `ocaml-git` (@dinosaure, mirage/ocaml-git#395)
- Delete useless constraints on digestif's signature (@dinosaure, mirage/ocaml-git#399)
- Add support of CoHTTP with UNIX and MirageOS (@ulugbekna, mirage/ocaml-git#400)
- Add progress reporting on fetch command (@ulugbekna, mirage/ocaml-git#405)
- Lint dependencies on packages (`git-cohttp-unix` and `git-cohttp-mirage`)
  and update to the last version of CoHTTP (@hannesm, mirage/ocaml-git#407)
- Fix internal `Cstruct_append` implementation (@dinosaure, mirage/ocaml-git#401)
- Implement shallow commit (@dinosaure, mirage/ocaml-git#402)
- Update to `conduit.3.0.0` (@dinosaure, mirage/ocaml-git#408) (deleted by the integration of `mimic`)
- Delete use of `ocurl` (@dinosaure, mirage/ocaml-git#410)
- Delete the useless **old** `git-mirage` package (@hannesm, mirage/ocaml-git#411)
- Fix about unresolved endpoint with `conduit.3.0.0` (@dinosaure, mirage/ocaml-git#412)
- Refactors fetch command (@ulugbekna, mirage/ocaml-git#404)
- Fix ephemerons about temporary devices (@dinosaure, mirage/ocaml-git#413)
- Implementation of `ogit-fetch` as an example (@ulugbekna, mirage/ocaml-git#406)
- Rename `nss` to `git-nss` (@dinosaure, mirage/ocaml-git#415)
- Refactors `git-nss` (@ulugbekna, mirage/ocaml-git#416)
- Update README.md (@ulugbekna, mirage/ocaml-git#417)
- Replace deprecated `Fmt` functions (@ulugbekna, mirage/ocaml-git#421)
- Delete physical equality (@ulugbekna, mirage/ocaml-git#422)
- Rename `prelude` argument by `uses_git_transport` (@ulugbekna, mirage/ocaml-git#423)
- Refactors Smart decoder (@ulugbekna, mirage/ocaml-git#424)
- Constraint to use `fmt.0.8.7` (@dinosaure, mirage/ocaml-git#425)
- Small refactors in `git-nss` (@dinosaure, mirage/ocaml-git#427)
- Delete `conduit.3.0.0` and replace it by `mimic` (@dinosaure, mirage/ocaml-git#428)
- Delete the useless `verify` function on `fetch` and `push` (@dinosaure, mirage/ocaml-git#429)
- Delete `pin-depends` on `awa` (@dinosaure, mirage/ocaml-git#431)
dinosaure added a commit to dinosaure/opam-repository that referenced this pull request Jan 9, 2021
…t-unix and git-mirage (3.0.0)

CHANGES:

- Rewrite of `ocaml-git` (@dinosaure, mirage/ocaml-git#395)
- Delete useless constraints on digestif's signature (@dinosaure, mirage/ocaml-git#399)
- Add support of CoHTTP with UNIX and MirageOS (@ulugbekna, mirage/ocaml-git#400)
- Add progress reporting on fetch command (@ulugbekna, mirage/ocaml-git#405)
- Lint dependencies on packages (`git-cohttp-unix` and `git-cohttp-mirage`)
  and update to the last version of CoHTTP (@hannesm, mirage/ocaml-git#407)
- Fix internal `Cstruct_append` implementation (@dinosaure, mirage/ocaml-git#401)
- Implement shallow commit (@dinosaure, mirage/ocaml-git#402)
- Update to `conduit.3.0.0` (@dinosaure, mirage/ocaml-git#408) (deleted by the integration of `mimic`)
- Delete use of `ocurl` (@dinosaure, mirage/ocaml-git#410)
- Delete the useless **old** `git-mirage` package (@hannesm, mirage/ocaml-git#411)
- Fix about unresolved endpoint with `conduit.3.0.0` (@dinosaure, mirage/ocaml-git#412)
- Refactors fetch command (@ulugbekna, mirage/ocaml-git#404)
- Fix ephemerons about temporary devices (@dinosaure, mirage/ocaml-git#413)
- Implementation of `ogit-fetch` as an example (@ulugbekna, mirage/ocaml-git#406)
- Rename `nss` to `git-nss` (@dinosaure, mirage/ocaml-git#415)
- Refactors `git-nss` (@ulugbekna, mirage/ocaml-git#416)
- Update README.md (@ulugbekna, mirage/ocaml-git#417)
- Replace deprecated `Fmt` functions (@ulugbekna, mirage/ocaml-git#421)
- Delete physical equality (@ulugbekna, mirage/ocaml-git#422)
- Rename `prelude` argument by `uses_git_transport` (@ulugbekna, mirage/ocaml-git#423)
- Refactors Smart decoder (@ulugbekna, mirage/ocaml-git#424)
- Constraint to use `fmt.0.8.7` (@dinosaure, mirage/ocaml-git#425)
- Small refactors in `git-nss` (@dinosaure, mirage/ocaml-git#427)
- Delete `conduit.3.0.0` and replace it by `mimic` (@dinosaure, mirage/ocaml-git#428)
- Delete the useless `verify` function on `fetch` and `push` (@dinosaure, mirage/ocaml-git#429)
- Delete `pin-depends` on `awa` (@dinosaure, mirage/ocaml-git#431)
dinosaure added a commit to dinosaure/opam-repository that referenced this pull request Jan 9, 2021
…t-unix and git-mirage (3.0.0)

CHANGES:

- Rewrite of `ocaml-git` (@dinosaure, mirage/ocaml-git#395)
- Delete useless constraints on digestif's signature (@dinosaure, mirage/ocaml-git#399)
- Add support of CoHTTP with UNIX and MirageOS (@ulugbekna, mirage/ocaml-git#400)
- Add progress reporting on fetch command (@ulugbekna, mirage/ocaml-git#405)
- Lint dependencies on packages (`git-cohttp-unix` and `git-cohttp-mirage`)
  and update to the last version of CoHTTP (@hannesm, mirage/ocaml-git#407)
- Fix internal `Cstruct_append` implementation (@dinosaure, mirage/ocaml-git#401)
- Implement shallow commit (@dinosaure, mirage/ocaml-git#402)
- Update to `conduit.3.0.0` (@dinosaure, mirage/ocaml-git#408) (deleted by the integration of `mimic`)
- Delete use of `ocurl` (@dinosaure, mirage/ocaml-git#410)
- Delete the useless **old** `git-mirage` package (@hannesm, mirage/ocaml-git#411)
- Fix about unresolved endpoint with `conduit.3.0.0` (@dinosaure, mirage/ocaml-git#412)
- Refactors fetch command (@ulugbekna, mirage/ocaml-git#404)
- Fix ephemerons about temporary devices (@dinosaure, mirage/ocaml-git#413)
- Implementation of `ogit-fetch` as an example (@ulugbekna, mirage/ocaml-git#406)
- Rename `nss` to `git-nss` (@dinosaure, mirage/ocaml-git#415)
- Refactors `git-nss` (@ulugbekna, mirage/ocaml-git#416)
- Update README.md (@ulugbekna, mirage/ocaml-git#417)
- Replace deprecated `Fmt` functions (@ulugbekna, mirage/ocaml-git#421)
- Delete physical equality (@ulugbekna, mirage/ocaml-git#422)
- Rename `prelude` argument by `uses_git_transport` (@ulugbekna, mirage/ocaml-git#423)
- Refactors Smart decoder (@ulugbekna, mirage/ocaml-git#424)
- Constraint to use `fmt.0.8.7` (@dinosaure, mirage/ocaml-git#425)
- Small refactors in `git-nss` (@dinosaure, mirage/ocaml-git#427)
- Delete `conduit.3.0.0` and replace it by `mimic` (@dinosaure, mirage/ocaml-git#428)
- Delete the useless `verify` function on `fetch` and `push` (@dinosaure, mirage/ocaml-git#429)
- Delete `pin-depends` on `awa` (@dinosaure, mirage/ocaml-git#431)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant