Implements ogit-fetch by ulugbekna · Pull Request #406 · mirage/ocaml-git

ulugbekna · 2020-09-28T16:41:30Z

Implements ogit-fetch supports

various transport: git://, http(s), and SSH
progress reporting
support for 'src_ref:dst_ref' where src_ref value is written to dst_ref

dinosaure · 2020-10-12T07:03:00Z

According the merge of #404, this PR should follow but it seems that:

the PR introduces some bad things such as >>>> HEAD (so, some unfinished resolution of conflicts).
awa-ssh is missing in OPAM files (you should add a pin-depends with Conduit.3.0.0 awa-ssh#19
About this point, a release of Conduit will fix such requirement but it seems that the release is locked by some details

If you have the time, can you refresh this PR with the new state of master (I can try to do that if you want)? In other side, it's a great work - I mean your PRs (not only this one) discovered some weird cases and improve globally the code 👍 !

ulugbekna · 2020-10-12T09:25:30Z

Oops, sorry about the conflicts. I thought I rebased and pushed long time ago.

I hope I got new dependencies for git-unix right. Is there a way (using opam) to check if all dune deps are present in the opam file?

dinosaure · 2020-10-12T09:30:52Z

I hope I got new dependencies for git-unix right. Is there a way (using opam) to check if all dune deps are present in the opam file?

It exists a way to generate the OPAM file from the dune file, but I don't know how to use it :/

ulugbekna · 2020-10-12T09:52:26Z

I know about this for generating opam files using dune, but that's not very helpful in detecting if I am missing some deps in my opam file which are actually included in the dune file.

ulugbekna · 2020-10-14T13:17:21Z

fixed and rebased :-)

@dinosaure

… git-unix (3.0.0) CHANGES: - Rewrite of `ocaml-git` (@dinosaure, mirage/ocaml-git#395) - Delete useless constraints on digestif's signature (@dinosaure, mirage/ocaml-git#399) - Add support of CoHTTP with UNIX and MirageOS (@ulugbekna, mirage/ocaml-git#400) - Add progress reporting on fetch command (@ulugbekna, mirage/ocaml-git#405) - Lint dependencies on packages (`git-cohttp-unix` and `git-cohttp-mirage`) and update to the last version of CoHTTP (@hannesm, mirage/ocaml-git#407) - Fix internal `Cstruct_append` implementation (@dinosaure, mirage/ocaml-git#401) - Implement shallow commit (@dinosaure, mirage/ocaml-git#402) - Update to `conduit.3.0.0` (@dinosaure, mirage/ocaml-git#408) (deleted by the integration of `mimic`) - Delete use of `ocurl` (@dinosaure, mirage/ocaml-git#410) - Delete the useless **old** `git-mirage` package (@hannesm, mirage/ocaml-git#411) - Fix about unresolved endpoint with `conduit.3.0.0` (@dinosaure, mirage/ocaml-git#412) - Refactors fetch command (@ulugbekna, mirage/ocaml-git#404) - Fix ephemerons about temporary devices (@dinosaure, mirage/ocaml-git#413) - Implementation of `ogit-fetch` as an example (@ulugbekna, mirage/ocaml-git#406) - Rename `nss` to `git-nss` (@dinosaure, mirage/ocaml-git#415) - Refactors `git-nss` (@ulugbekna, mirage/ocaml-git#416) - Update README.md (@ulugbekna, mirage/ocaml-git#417) - Replace deprecated `Fmt` functions (@ulugbekna, mirage/ocaml-git#421) - Delete physical equality (@ulugbekna, mirage/ocaml-git#422) - Rename `prelude` argument by `uses_git_transport` (@ulugbekna, mirage/ocaml-git#423) - Refactors Smart decoder (@ulugbekna, mirage/ocaml-git#424) - Constraint to use `fmt.0.8.7` (@dinosaure, mirage/ocaml-git#425) - Small refactors in `git-nss` (@dinosaure, mirage/ocaml-git#427) - Delete `conduit.3.0.0` and replace it by `mimic` (@dinosaure, mirage/ocaml-git#428) - Delete the useless `verify` function on `fetch` and `push` (@dinosaure, mirage/ocaml-git#429) - Delete `pin-depends` on `awa` (@dinosaure, mirage/ocaml-git#431)

@dinosaure

…t-unix and git-mirage (3.0.0) CHANGES: - Rewrite of `ocaml-git` (@dinosaure, mirage/ocaml-git#395) - Delete useless constraints on digestif's signature (@dinosaure, mirage/ocaml-git#399) - Add support of CoHTTP with UNIX and MirageOS (@ulugbekna, mirage/ocaml-git#400) - Add progress reporting on fetch command (@ulugbekna, mirage/ocaml-git#405) - Lint dependencies on packages (`git-cohttp-unix` and `git-cohttp-mirage`) and update to the last version of CoHTTP (@hannesm, mirage/ocaml-git#407) - Fix internal `Cstruct_append` implementation (@dinosaure, mirage/ocaml-git#401) - Implement shallow commit (@dinosaure, mirage/ocaml-git#402) - Update to `conduit.3.0.0` (@dinosaure, mirage/ocaml-git#408) (deleted by the integration of `mimic`) - Delete use of `ocurl` (@dinosaure, mirage/ocaml-git#410) - Delete the useless **old** `git-mirage` package (@hannesm, mirage/ocaml-git#411) - Fix about unresolved endpoint with `conduit.3.0.0` (@dinosaure, mirage/ocaml-git#412) - Refactors fetch command (@ulugbekna, mirage/ocaml-git#404) - Fix ephemerons about temporary devices (@dinosaure, mirage/ocaml-git#413) - Implementation of `ogit-fetch` as an example (@ulugbekna, mirage/ocaml-git#406) - Rename `nss` to `git-nss` (@dinosaure, mirage/ocaml-git#415) - Refactors `git-nss` (@ulugbekna, mirage/ocaml-git#416) - Update README.md (@ulugbekna, mirage/ocaml-git#417) - Replace deprecated `Fmt` functions (@ulugbekna, mirage/ocaml-git#421) - Delete physical equality (@ulugbekna, mirage/ocaml-git#422) - Rename `prelude` argument by `uses_git_transport` (@ulugbekna, mirage/ocaml-git#423) - Refactors Smart decoder (@ulugbekna, mirage/ocaml-git#424) - Constraint to use `fmt.0.8.7` (@dinosaure, mirage/ocaml-git#425) - Small refactors in `git-nss` (@dinosaure, mirage/ocaml-git#427) - Delete `conduit.3.0.0` and replace it by `mimic` (@dinosaure, mirage/ocaml-git#428) - Delete the useless `verify` function on `fetch` and `push` (@dinosaure, mirage/ocaml-git#429) - Delete `pin-depends` on `awa` (@dinosaure, mirage/ocaml-git#431)

@dinosaure

…t-unix and git-mirage (3.0.0) CHANGES: - Rewrite of `ocaml-git` (@dinosaure, mirage/ocaml-git#395) - Delete useless constraints on digestif's signature (@dinosaure, mirage/ocaml-git#399) - Add support of CoHTTP with UNIX and MirageOS (@ulugbekna, mirage/ocaml-git#400) - Add progress reporting on fetch command (@ulugbekna, mirage/ocaml-git#405) - Lint dependencies on packages (`git-cohttp-unix` and `git-cohttp-mirage`) and update to the last version of CoHTTP (@hannesm, mirage/ocaml-git#407) - Fix internal `Cstruct_append` implementation (@dinosaure, mirage/ocaml-git#401) - Implement shallow commit (@dinosaure, mirage/ocaml-git#402) - Update to `conduit.3.0.0` (@dinosaure, mirage/ocaml-git#408) (deleted by the integration of `mimic`) - Delete use of `ocurl` (@dinosaure, mirage/ocaml-git#410) - Delete the useless **old** `git-mirage` package (@hannesm, mirage/ocaml-git#411) - Fix about unresolved endpoint with `conduit.3.0.0` (@dinosaure, mirage/ocaml-git#412) - Refactors fetch command (@ulugbekna, mirage/ocaml-git#404) - Fix ephemerons about temporary devices (@dinosaure, mirage/ocaml-git#413) - Implementation of `ogit-fetch` as an example (@ulugbekna, mirage/ocaml-git#406) - Rename `nss` to `git-nss` (@dinosaure, mirage/ocaml-git#415) - Refactors `git-nss` (@ulugbekna, mirage/ocaml-git#416) - Update README.md (@ulugbekna, mirage/ocaml-git#417) - Replace deprecated `Fmt` functions (@ulugbekna, mirage/ocaml-git#421) - Delete physical equality (@ulugbekna, mirage/ocaml-git#422) - Rename `prelude` argument by `uses_git_transport` (@ulugbekna, mirage/ocaml-git#423) - Refactors Smart decoder (@ulugbekna, mirage/ocaml-git#424) - Constraint to use `fmt.0.8.7` (@dinosaure, mirage/ocaml-git#425) - Small refactors in `git-nss` (@dinosaure, mirage/ocaml-git#427) - Delete `conduit.3.0.0` and replace it by `mimic` (@dinosaure, mirage/ocaml-git#428) - Delete the useless `verify` function on `fetch` and `push` (@dinosaure, mirage/ocaml-git#429) - Delete `pin-depends` on `awa` (@dinosaure, mirage/ocaml-git#431)

ulugbekna marked this pull request as ready for review September 29, 2020 08:08

dinosaure reviewed Sep 30, 2020

View reviewed changes

Comment thread src/git-unix/ogit-fetch/main.ml

ulugbekna force-pushed the impl-ogit-fetch branch from 864b279 to 4ef37b6 Compare October 8, 2020 13:17

ulugbekna force-pushed the impl-ogit-fetch branch from 4ef37b6 to ba2c604 Compare October 12, 2020 09:23

dinosaure reviewed Oct 14, 2020

View reviewed changes

Comment thread git-unix.opam Outdated

implement ogit-fetch

ca7c227

ulugbekna force-pushed the impl-ogit-fetch branch from 5619004 to 112e544 Compare October 14, 2020 13:17

fix incorrect pin-depends by adding version to pinned deps

2c1d1fc

dinosaure force-pushed the impl-ogit-fetch branch from 112e544 to 2c1d1fc Compare October 14, 2020 13:32

dinosaure added 2 commits October 14, 2020 15:49

Upgrade the appveyor.yml file to include git-cohttp{,-unix}

fed11d5

Update Travis CI with new packages git-cohttp & git-cohttp-unix

d387ff7

dinosaure merged commit 8e7cf58 into mirage:master Oct 15, 2020

dinosaure mentioned this pull request Jan 9, 2021

[new release] git, git-cohttp, git-cohttp-unix, git-cohttp-mirage and git-unix (3.0.0) ocaml/opam-repository#17950

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implements ogit-fetch#406

Implements ogit-fetch#406
dinosaure merged 4 commits into
mirage:masterfrom
ulugbekna:impl-ogit-fetch

ulugbekna commented Sep 28, 2020

Uh oh!

Uh oh!

dinosaure commented Oct 12, 2020

Uh oh!

ulugbekna commented Oct 12, 2020

Uh oh!

dinosaure commented Oct 12, 2020

Uh oh!

ulugbekna commented Oct 12, 2020

Uh oh!

Uh oh!

ulugbekna commented Oct 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ulugbekna commented Sep 28, 2020

Uh oh!

Uh oh!

dinosaure commented Oct 12, 2020

Uh oh!

ulugbekna commented Oct 12, 2020

Uh oh!

dinosaure commented Oct 12, 2020

Uh oh!

ulugbekna commented Oct 12, 2020

Uh oh!

Uh oh!

ulugbekna commented Oct 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants