Skip to content

irmin-http: remove exception handling workaround in tests #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samoht merged 1 commit into from
Jul 30, 2019
Merged

irmin-http: remove exception handling workaround in tests #819

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions test/irmin-http/test_http.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,6 @@ let http_store (module S : Irmin_test.S) =
let module M = Irmin_http.Client (Client) (S) in
(module M : Irmin_test.S)

(* See https://github.com/mirage/ocaml-cohttp/issues/511 *)
let () =
Lwt.async_exception_hook :=
fun e -> Fmt.pr "Async exception caught: %a" Fmt.exn e

let remove file = try Unix.unlink file with _ -> ()

let signal pid =
Expand Down Expand Up @@ -95,7 +90,9 @@ let serve servers n =
>>= fun () ->
let mode = `Unix_domain_socket (`File socket) in
Conduit_lwt_unix.set_max_active 100;
Cohttp_lwt_unix.Server.create ~mode spec
Cohttp_lwt_unix.Server.create
~on_exn:(Fmt.pr "Async exception caught: %a" Fmt.exn)
~mode spec
in
Lwt_main.run (server ())

Expand Down