From f6aeb7603d10ddfce15a0b2884f0a4efc7bd2b48 Mon Sep 17 00:00:00 2001
From: Thomas Gazagnaire <thomas@gazagnaire.org>
Date: Tue, 11 Aug 2020 13:40:50 +0200
Subject: [PATCH] Remove caching of buffers

We are now caching the IO instances instead. Also, this could lead
to tricky bugs when we start to rename file.

This is similar to https://github.com/mirage/index/commit/f8fdc9367bab6acfce0800c4e2aa928bbbe3eb01
---
 src/irmin-pack/IO.ml | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/src/irmin-pack/IO.ml b/src/irmin-pack/IO.ml
index 3958d0f1a7..40c83e2ad1 100644
--- a/src/irmin-pack/IO.ml
+++ b/src/irmin-pack/IO.ml
@@ -151,15 +151,6 @@ module Unix : S = struct
     t.flushed <- header;
     Buffer.clear t.buf
 
-  let buffers = Hashtbl.create 256
-
-  let buffer file =
-    try Hashtbl.find buffers file
-    with Not_found ->
-      let buf = Buffer.create (4 * 1024) in
-      Hashtbl.add buffers file buf;
-      buf
-
   let v ~fresh ~version:current_version ~readonly file =
     assert (String.length current_version = 8);
     let v ~offset ~version raw =
@@ -169,7 +160,7 @@ module Unix : S = struct
         offset;
         raw;
         readonly;
-        buf = buffer file;
+        buf = Buffer.create (4 * 1024);
         flushed = header ++ offset;
       }
     in