Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0 renewal milestone #23

Open
5 of 7 tasks
minwook-shin opened this issue Nov 9, 2024 · 2 comments
Open
5 of 7 tasks

2.0 renewal milestone #23

minwook-shin opened this issue Nov 9, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@minwook-shin
Copy link
Owner

minwook-shin commented Nov 9, 2024

2.0 Renewal Milestone

Overview

we will be refactoring the project to use the Facade design pattern.

will simplify the interface for interacting with the Notion API by providing a unified interface to a set of interfaces.

Implementation Plan

  • Step 1: Create the Facade Class
    will create NotionDatabase class that will encapsulate the interactions.

  • Step 2: Refactor Existing Code
    refactor the code to use the NotionDatabase class instead of directly interacting classes.

  • Step 3: Update Documentation and Testing
    update the documentation to changes and provide examples.


By refactoring the project to use the Facade design pattern, we aim to simplify the interface for interacting with the Notion API, improve code maintainability, and enhance usability.

Please use GitHub Issues to communicate and track the progress of this milestone.

AS-IS

# List Database
S = Search(integrations_token=NOTION_KEY)
S.search_database(query="", sort={"direction": Direction.ascending, "timestamp": Timestamp.last_edited_time})

TO-BE

# List Database
NotionDatabase.search(integrations_token=NOTION_KEY, query="", sort={"direction": Direction.ascending, "timestamp": Timestamp.last_edited_time})
@minwook-shin minwook-shin added the enhancement New feature or request label Nov 9, 2024
@minwook-shin minwook-shin added this to the 2.0 milestone Nov 9, 2024
@minwook-shin minwook-shin self-assigned this Nov 9, 2024
@minwook-shin minwook-shin pinned this issue Nov 9, 2024
@minwook-shin
Copy link
Owner Author

step 1 was developed and deployed to develop version.

pip install notion-database==2.0.dev0

@minwook-shin
Copy link
Owner Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant