Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduled start date on 28-31th not working as expected #3810

Open
madelondohmen opened this issue Nov 7, 2024 · 1 comment · May be fixed by #3831
Open

Scheduled start date on 28-31th not working as expected #3810

madelondohmen opened this issue Nov 7, 2024 · 1 comment · May be fixed by #3831
Assignees
Labels
bug Something isn't working

Comments

@madelondohmen
Copy link
Contributor

madelondohmen commented Nov 7, 2024

Describe the bug
Currently, when a user enters a start date for a scheduled report on the 28th, 29th, 30th or 31th, the cron expression will be * * 28-31 * *.
This is not the expected behaviour.

To Reproduce
Steps to reproduce the behavior:

  1. Schedule a report
  2. Enter a date (28, 29, 30 or 31th)
  3. Check the cron expression on the Scheduled Report page

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
Image

@madelondohmen madelondohmen added the bug Something isn't working label Nov 7, 2024
@madelondohmen madelondohmen self-assigned this Nov 7, 2024
@madelondohmen madelondohmen added this to KAT Nov 7, 2024
@madelondohmen madelondohmen moved this to In Progress in KAT Nov 7, 2024
@madelondohmen madelondohmen changed the title Scheduled date on 28-31th not working as expected Scheduled start date on 28-31th not working as expected Nov 7, 2024
@underdarknl
Copy link
Contributor

We can use l for last day of month instead of a specific day number.
https://pypi.org/project/croniter/#toc-entry-99
I propose:
If the last day of the month > 27 we should also set to l

@madelondohmen madelondohmen linked a pull request Nov 12, 2024 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Review
Development

Successfully merging a pull request may close this issue.

2 participants