Skip to content

Conversation

@harshavardhana
Copy link
Member

Description

fix: parse and save retainUntilDate in correct time format

Motivation and Context

PutObjectRetention seems to save object metadata retain until
date in time.RFC3339 format, instead it should be iso8601TimeFormat.

This also needs to be the parsing logic as well during
replication of metadata.

How to test this PR?

Nothing special just observe the saved metadata with different APIs.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

PutObjectRetention seems to save object metadata retain until
date in time.RFC3339 format, instead it should be iso8601TimeFormat.

This also needs to be the parsing logic as well during
replication of metadata.
@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-large-bucket.sh ✔️
mint-fs.sh ✔️
mint-gateway-s3.sh ✔️
mint-erasure.sh ✔️
mint-dist-erasure.sh ✔️
mint-compress-encrypt-dist-erasure.sh ✔️
mint-pools.sh ✔️
Deleting image on docker hub
Deleting image locally

@harshavardhana harshavardhana merged commit 50a8ba6 into minio:master Sep 23, 2022
@harshavardhana harshavardhana deleted the fix-time-parsing branch September 23, 2022 15:49
@bh4t bh4t added the bugfix label Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants