Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to use IHttpClientFactory instead of RestSharp as an HTTP component? #424

Closed
yilezhu opened this issue Jun 28, 2020 · 5 comments

Comments

@yilezhu
Copy link

yilezhu commented Jun 28, 2020

Not long ago, I tested and found that there was a problem of TCP leakage。Later, it was found that the problem was with the RestSharp component.See this issue for details #411 .
restsharp/RestSharp#1406
I tried to migrate the IHttpClientFactory component and found it failed. so is there any official plan to use IHttpClientFactory instead of RestSharp as an HTTP component? Otherwise, this problem will be perplexed all the time。

@harshavardhana
Copy link
Member

Not long ago, I tested and found that there was a problem of TCP leakage。Later, it was found that the problem was with the RestSharp component.See this issue for details #411 .
restsharp/RestSharp#1406
I tried to migrate the IHttpClientFactory component and found it failed. so is there any official plan to use IHttpClientFactory instead of RestSharp as an HTTP component? Otherwise, this problem will be perplexed all the time。

We can definitely do this a breaking change as we add new APIs // cc @poornas @kannappanr

@xujiesh0510
Copy link

HI. Any progress on this issue? To be frank, This is not a production-ready library without solving this issue.

@xujiesh0510
Copy link

@yilezhu , Have you implemented a simple version of minio-dotnet using HttpClientFactory ?

@BigUstad
Copy link
Contributor

As @harshavardhana remarked. It'd be a breaking change & we'd need to rewrite the APIs. The product development team is looking into it and they will make a decision.

@harshavardhana
Copy link
Member

Fixed by #551

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants